feat: add late inline support to Jeandle inliner - #113
Open
minchao1024 wants to merge 2 commits into
Open
minchao1024 wants to merge 2 commits into
minchao1024 wants to merge 2 commits into
Conversation
Signed-off-by: minchao1024 <minchao04@163.com>
Contributor
Merge Protections🔴 1 of 2 protections blocking · waiting on 👀 reviews
🔴 Require a review from a maintainer.Waiting for
This rule is failing.
Show 1 satisfied protection🟢 Pull request title format.
|
Signed-off-by: minchao1024 <minchao04@163.com>
taofengliu
reviewed
Sep 9, 2026
| if (InLateInlinePhase) { | ||
| HasLateInlineCandidates = false; | ||
| } | ||
| break; |
Member
There was a problem hiding this comment.
We cannot break here because every callee's node count cut off is different. We should try to inline other callees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s):
issue #106
What this PR does / why we need it:
Replace IsOkToInline with GetInlineDecision to support eager, delayed,
denied, and node-count-cutoff decisions.
Add one-way eager-to-late scheduling and depth-first inline processing.
Preserve inline scope metadata across rounds, prevent failed late-inline
candidates from being retried, and correctly invalidate analyses when
adding noinline attributes.
Update callback replay logs and add tests for successful and failed
late inlining.