fix: handle invokeBasic target signature mismatch - #111
Merged
Merged
Conversation
Contributor
Merge Protections🟢 All 2 merge protections satisfied — ready to merge. Show 2 satisfied protections🟢 Require a review from a maintainer.
🟢 Pull request title format.
|
Contributor
Author
|
|
Rebuild invokeBasic calls with the actual MethodHandle target signature instead of reusing the outer wrapper signature. Signed-off-by: xiejf2020 <xiejf2020@outlook.com>
xiejf2020
force-pushed
the
fix-invokebasic-cha
branch
from
September 17, 2026 09:35
169a43b to
858c887
Compare
taofengliu
approved these changes
Sep 18, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix
_invokeBasicCHA devirtualization for adapted MethodHandles whose wrapper signature differs from the target method signature. The optimizer now resolves the concrete MethodHandle target, validates the target argument types, rebuilds the direct call with the target’s actual function type, and safely handles discarded return values forvoidwrappers. Ordinary_linkTo*CHA handling remains unchanged. This keeps the generated LLVM call type consistent with the real Java target and avoids correctness failures caused by reusing the outer wrapper signature.