Repository navigation
fix: prevent responsive wrappers from swallowing horizontal scroll events (#1392) - #1396
Merged
jbetancur merged 1 commit intoSep 28, 2026
Conversation
✅ Deploy Preview for react-data-table-component ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Fixes horizontal scroll gestures being trapped by responsive table wrappers.
Changes:
- Removed horizontal overscroll containment from responsive and fixed wrappers.
- Preserved local table scrolling and touch panning.
| File | Description |
|---|---|
src/DataTable.css |
Restores natural horizontal scroll chaining. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1392
This PR removes
overscroll-behavior-x: contain;from.rdt_responsiveWrapperScrolland.rdt_responsiveWrapperFixedinsrc/DataTable.css.Problem & Root Cause
Previously,
.rdt_responsiveWrapperScrolland.rdt_responsiveWrapperFixedhadoverscroll-behavior-x: contain;defined. Because.rdt_responsiveWrappercovers the table bounds (100% width), any horizontal scrolling/swiping gesture initiated while hovering over or touching the table was trapped and prevented from bubbling / chaining to parent scrollable containers or the window (especially noticeable on mobile touch or trackpad horizontal swipe). When the table had no horizontal overflow or reached its scroll boundaries, outer horizontal scrolling was swallowed.Solution
overscroll-behavior-x: contain;from.rdt_responsiveWrapperScrolland.rdt_responsiveWrapperFixed.autoallows natural scroll chaining to ancestor containers.touch-action: pan-x pan-y;and-webkit-overflow-scrolling: touch;) remain fully functional.Verification
npm test— 718 tests passing).npm run typecheck).