Skip to content

Nullable is not working in to_struct() #140

Description

@buriedguns
class Person(models.Base):
    nickname = fields.StringField(nullable=True)
person = Person()
>>> person.to_struct()
{
    'nickname': None,
}

If you try to reproduce the example above from your documentation (Person with nullable Nickname to_struct()) it will return nothing, and not a 'nickname': None.

That's because there's no nullable verification in parser.py to_struct() function. Could you add it please, like in the example below?

def to_struct(model):
    """Cast instance of model to python structure.

    :param model: Model to be casted.
    :rtype: ``dict``

    """
    model.validate()

    resp = {}
    for _, name, field in model.iterate_with_name():
        value = field.__get__(model)
        if value is None and not field.nullable:
            continue

        value = field.to_struct(value)
        resp[name] = value
    return resp

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions