fix: make clip api less expensive - #5871
Conversation
|
Sorry but I don't think we are going to accept this PR as the whole point of the In the other hand seems like the clips feature has been removed from Youtube, but since I don't have any clip ID to test that, I can't really verify that. |
|
I see, thank you for providing a test clip link, I'm still against removing the video information from the clips API because that would involve a breaking change. If you want to make the API less expensive, a query parameter like What do you think @unixfox ? |
|
I think removing it is probably a bad idea, people might depend on it. From a quick search on https://github.com/search?q=%2Fapi%2Fv1%2Fclips+invidious&type=code. I found playlet using that API endpoint: https://github.com/iBicha/playlet/blob/48b10e8618924cadfe2e96beac95061b97586bb9/playlet-web/src/lib/Api/InvidiousApi.ts#L84 |
|
Ahh, I think I must have had a typo in my original GitHub search; I wasn't aware playlet was using this. I'll close this PR and opt for using the resolveurl api endpoint (and parsing the params in FreeTube instead). Sorry about that |
Checklist
AI Disclosure
Pull request description
I added the clip api endpoint to Invidious for FreeTube to use and am now finally getting around to adding support in FreeTube.
The endpoint is unnecessarily expensive for no good reason with the
get_videocall so this PR replaces it with just the video_id instead. I haven't been able to find a client that uses this endpoint but would like to use it in FreeTube as part of: FreeTubeApp/FreeTube#9532Testing
{INVIDIOUS API}/api/v1/clips/UgkxxPM3BRphCAPLP88YoUGuj79KXPfpNNO_