Use pydantic in CLI - #122
Open
Yannicked wants to merge 11 commits into
Open
Conversation
Fixes issue with sim pull
Replace the hand-rolled json.dumps/CustomEncoder request bodies and res.json() dict indexing in RemoteAPI with the shared models from simdb.remote.models, so the client and server validate against one contract. Request bodies are now pydantic models serialised by serialise_request_data; responses are parsed with model_validate_json and try_request maps pydantic ValidationError onto the existing FailedConnection/RemoteError reporting. Watcher.to_model now maps the notification enum onto the single character the API reports, instead of emitting str(Notification.X).
# Conflicts: # src/simdb/remote/models.py # tests/cli/test_remote_api_version.py
Yannicked
requested review from
SimonPinches,
maarten-ic,
olivhoenen and
prasad-sawantdesai
as code owners
September 3, 2026 08:33
Yannicked
force-pushed
the
feature/remote_api_pydantic
branch
from
September 3, 2026 08:37
05e1f1a to
ce8a234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.