Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Changed
^^^^^^^

* **Breaking:** Changed the Cabinet and Lift task families to use Newton MJWarp

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry explicitly classifies the default-backend switch as breaking, but I could not find a prior deprecation for the Cabinet or Lift default behavior. Please reconcile this with the repository policy that breaking changes require a deprecation first, or clarify why this workflow-default change is exempt.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default switch is intentional for the 3.0 release. Per the release direction, we are documenting the direct breaking migration in the changelog rather than adding a deprecation alias or transitional behavior.

by default. Pass an explicit physics preset to retain Isaac Sim PhysX.
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ class CabinetSimCfg(PresetCfg):
physx: SimulationCfg = isaacsim_physx.replace(
physics=PhysxAutoCfg(isaacsim_physx=isaacsim_physx.physics, ovphysx=ovphysx.physics)
)
default: SimulationCfg = isaacsim_physx
newton_mjwarp: SimulationCfg = SimulationCfg(
dt=1 / 600,
render_interval=1,
Expand All @@ -125,6 +124,7 @@ class CabinetSimCfg(PresetCfg):
default_visualizer_cfg=VisualizerCfg(eye=(-2.0, 2.0, 2.0), lookat=(0.8, 0.0, 0.5)),
physics=NewtonCfg(solver_cfg=KaminoPADMMSolverCfg(max_contacts_per_world=64)),
)
default: SimulationCfg = newton_mjwarp


@configclass
Expand All @@ -138,9 +138,9 @@ class CabinetDecimationCfg(PresetCfg):
isaacsim_physx: int = 1
ovphysx: int = isaacsim_physx
physx: int = isaacsim_physx
default: int = isaacsim_physx
newton_mjwarp: int = 10
newton_kamino: int = 10
default: int = newton_mjwarp


##
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ class KukaAllegroPhysicsCfg(lift.PhysicsCfg):
gpu_found_lost_pairs_capacity=2**26,
)
physx = PhysxAutoCfg(isaacsim_physx=isaacsim_physx, ovphysx=ovphysx)
default = isaacsim_physx
newton_mjwarp = lift.PhysicsCfg().newton_mjwarp
default = newton_mjwarp


@configclass
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ class PhysicsCfg(PresetCfg):
debug_mode=False,
)
physx = PhysxAutoCfg(isaacsim_physx=isaacsim_physx)
default = isaacsim_physx
default = newton_mjwarp


@configclass
Expand Down
Loading