Skip to content

Fix the CI workflow - #213

Merged
bqminh merged 2 commits into
iqtree:masterfrom
thomaskf:bugfix
Sep 10, 2026
Merged

Fix the CI workflow#213
bqminh merged 2 commits into
iqtree:masterfrom
thomaskf:bugfix

Conversation

@thomaskf

@thomaskf thomaskf commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator
  • Moved the two new commands to the end of the list, so the other tests line up with their thresholds again.
  • The workflow now skips any test that has no threshold.
  • If a time or memory test fails, that single test is run again. It is reported as a failure only if it fails the second time as well. This avoids failures caused by a slow or busy CI machine.

…hmark commands that have no row in the threshold table, move the two new codon commands to the end of the benchmark test

@bqminh bqminh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the CI fix. Moreover, I'll remove all these new tests, because:

  • The CI is not meant to be an extensive test suite. For extensive testing, developers need to do it internally, and show the results via other means. Some test files may be uploaded to the PR to help reproduce the intended behaviour.
  • Instead, the CI checks a few most common use cases, making sure the behaviour is the same between IQTREE 2 and 3. So of course when there is new option/feature, this is not the place to test.
  • The CI auto builds the binaries, so that some users may early beta-test the versions before official release.

@bqminh
bqminh merged commit 69a89ac into iqtree:master Sep 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants