Fix the CI workflow - #213
Merged
Merged
Conversation
thomaskf
commented
Sep 9, 2026
Collaborator
- Moved the two new commands to the end of the list, so the other tests line up with their thresholds again.
- The workflow now skips any test that has no threshold.
- If a time or memory test fails, that single test is run again. It is reported as a failure only if it fails the second time as well. This avoids failures caused by a slow or busy CI machine.
…hmark commands that have no row in the threshold table, move the two new codon commands to the end of the benchmark test
bqminh
approved these changes
Sep 10, 2026
bqminh
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks for the CI fix. Moreover, I'll remove all these new tests, because:
- The CI is not meant to be an extensive test suite. For extensive testing, developers need to do it internally, and show the results via other means. Some test files may be uploaded to the PR to help reproduce the intended behaviour.
- Instead, the CI checks a few most common use cases, making sure the behaviour is the same between IQTREE 2 and 3. So of course when there is new option/feature, this is not the place to test.
- The CI auto builds the binaries, so that some users may early beta-test the versions before official release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.