Skip to content

Modify URI in create_collection3 to conditionally include page #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glenrobson wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Modify URI in create_collection3 to conditionally include page #162

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9391d2c
Modify URI in create_collection3 to conditionally include page
mathewjordan Sep 11, 2025
1831ca6
Merge branch 'main' into issue-142
glenrobson Mar 19, 2026
0a0df1c
Adding unit test
glenrobson Mar 19, 2026
e28c742
A new review was added
glenrobson Apr 30, 2026
1605e7e
Format has changed in the test
glenrobson May 14, 2026
4fb06be
Adding timeouts and retries for IIIF image server
glenrobson May 15, 2026
d4f091f
Increasing timeout
glenrobson May 23, 2026
7036de5
Fixing test. Object now has two canvases, 1 video 1 image
glenrobson May 23, 2026
7394ad8
Manifest now has 2 canvases
glenrobson May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions iiify/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ def create_collection3(identifier, domain, page=1, rows=MAX_API_LIMIT):
# Get item metadata
metadata = requests.get('%s/metadata/%s' % (ARCHIVE, identifier)).json()

# Used to build up URIs for the manifest
uri = f"{domain}{identifier}/collection.json"
# Write Collection uri with conditional page segment
uri = f"{domain}{identifier}{f'/{page}' if page != 1 else ''}/collection.json"

config.configs['helpers.auto_fields.AutoLang'].auto_lang = "none"
collection = Collection(id=uri, label=metadata["metadata"]["title"])
Expand Down
5 changes: 5 additions & 0 deletions tests/test_collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ def test_sanitized_summary(self):
f"Expected summary to be sanitized but got: {collection['summary']['none'][0]}"
)

def test_unique_id_sub_page(self):
resp = self.test_app.get("/iiif/usgs_tx/2/collection.json?recache=True")
self.assertEqual(resp.status_code, 200)
collection = resp.json
self.assertEqual(collection['id'], "https://localhost/iiif/usgs_tx/2/collection.json", f"Expected unique ID for the second page of the results but got: {collection['id']}")

if __name__ == '__main__':
unittest.main()
Loading