Init thumbnail rework. - #145
Open
markpbaggett wants to merge 7 commits into
Open
Conversation
markpbaggett
marked this pull request as ready for review
September 18, 2025 20:39
Collaborator
|
Audio we think we can hard code dimensions Video we are thinking of removing height and width and testing with viewers as this is a 'should' in the spec. |
Collaborator
|
Discussing this in the 5th march call and wondered if the video thumbnail would be the same size as the video. We must have the height and width for the video as its required for the canvas. Audio should be static sizes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do?
Skips Cantaloupe for audio / video thumbnails and fixes Issue-141.
Manifest generation was slow for items with many audio/video files (e.g. taboca_201002_03, 251 canvases) because every thumbnail (including AV thumbnails) were routed through Cantaloupe's IIIF image service via create_thumbnail_from_iiif. For AV items this is unnecessary round-trip overhead per file and a needless dependency on the image server for content that isn't an image derivative.
This change runs things through addThumbnails based on mediatype: