[SYCL][E2E] Enable max_work_group_query test for OpenCL - #22920
Open
VerenaBeckham wants to merge 1 commit into
Open
[SYCL][E2E] Enable max_work_group_query test for OpenCL#22920VerenaBeckham wants to merge 1 commit into
VerenaBeckham wants to merge 1 commit into
Conversation
This test was marked as not supported on OpenCL in error in commit f19914a.
Contributor
Author
|
Tagging @abagusetty as the author of the commit referenced. |
| @@ -1,5 +1,5 @@ | |||
| // RUN: %{build} -o %t.out | |||
| // REQUIRES: cuda || hip || level_zero | |||
| // REQUIRES: cuda || hip || level_zero || opencl | |||
Contributor
There was a problem hiding this comment.
If it's supported on all platforms then we can just drop this.
Suggested change
| // REQUIRES: cuda || hip || level_zero || opencl |
Contributor
@VerenaBeckham IIRC back then, OpenCL didnt have the capability. Thanks for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was marked as not supported on OpenCL in error in commit f19914a.