Skip to content

Zero left/right cell padding in theme_gtsummary_roche() - #310

Closed
Melkiades wants to merge 2 commits into
mainfrom
309_theme_lr_padding@main
Closed

Melkiades wants to merge 2 commits into
mainfrom
309_theme_lr_padding@main

Conversation

@Melkiades

Copy link
Copy Markdown
Contributor

The theme already zeroed top and bottom padding but left flextable's default 5pt left/right, adding ~0.19in of unused width to every column. Gridline-free listings do not need it. (#309)

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

The theme already zeroed top and bottom padding but left flextable's default
5pt left/right, adding ~0.19in of unused width to every column. Gridline-free
listings do not need it. (#309)
Zeroing horizontal padding made cell text touch the column border. Revert
to flextable's default left/right padding; keep top/bottom at zero.
@Melkiades Melkiades closed this Aug 27, 2026
@Melkiades
Melkiades deleted the 309_theme_lr_padding@main branch August 27, 2026 14:43
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant