[Melkiades]

What changes are proposed in this pull request?

• tbl_null_report() now centers its message, so with no body content it reads as a "no data" panel spanning the table instead of hugging the left edge. (Center tbl_null_report() message #305)

Reference GitHub issue associated with pull request. closes #305

---

Pre-review Checklist (if item does not apply, mark is as complete)

• All GitHub Action workflows pass with a ✅
• PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
• If a bug was fixed, a unit test was added.
• Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
• Request a reviewer

[github-actions]

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------
R/add_blank_rows.R                          63       0  100.00%
R/add_difference_row.R                     101       0  100.00%
R/add_forest_utils.R                        97      10  89.69%   76-79, 94-100
R/add_forest.R                             139       0  100.00%
R/add_hierarchical_count_row.R              33       0  100.00%
R/adjust_stat_columns_wrap.R                29       1  96.55%   59
R/annotate_gg_km.R                         141       0  100.00%
R/annotate_gg_pkc.R                        100       0  100.00%
R/annotate_gg.R                             83       0  100.00%
R/ard_tabulate_abnormal_by_baseline.R       65       0  100.00%
R/crane-package.R                            2       2  0.00%    26-27
R/deprecated.R                              21      21  0.00%    18-54
R/df_add_poolings.R                         41       0  100.00%
R/get_cox_pairwise_df.R                    163       0  100.00%
R/gg_km_utils.R                             39      14  64.10%   20-37
R/gg_km.R                                  143      37  74.13%   55-58, 75, 102, 176-181, 184-187, 197-199, 204-205, 239-241, 248-251, 255, 266-270, 283, 285-287
R/gg_lineplot.R                             94       0  100.00%
R/gg_mmrm_lineplot.R                       102       1  99.02%   106
R/gg_pkc_lineplot.R                         98       0  100.00%
R/gg_utils.R                               222       0  100.00%
R/label_roche.R                             72       0  100.00%
R/modify_header_rm_md.R                     18       2  88.89%   35-36
R/modify_split_caption.R                    26       0  100.00%
R/modify_zero_recode.R                      20       1  95.00%   64
R/pk_helper.R                              499       0  100.00%
R/reverse_difference_ci.R                   33       0  100.00%
R/tbl_baseline_chg.R                       188       0  100.00%
R/tbl_coxph.R                               90       1  98.89%   229
R/tbl_hierarchical_incidence_rate.R        291       4  98.63%   430-433
R/tbl_hierarchical_rate_and_count.R        339      13  96.17%   343, 425, 446-456
R/tbl_hierarchical_rate_by_grade.R         317       3  99.05%   169-171
R/tbl_listing.R                             35       0  100.00%
R/tbl_mmrm.R                               254       1  99.61%   393
R/tbl_null_report.R                         10       0  100.00%
R/tbl_rmpt.R                               157      12  92.36%   299-304, 316-321
R/tbl_roche_subgroups.R                    155       0  100.00%
R/tbl_roche_summary.R                       64       0  100.00%
R/tbl_shift.R                              116       0  100.00%
R/tbl_survfit_quantiles.R                  154       0  100.00%
R/tbl_survfit_times.R                       92       0  100.00%
R/tbl_with_pools.R                          64       0  100.00%
R/theme_gtsummary_roche.R                   87       1  98.85%   61
R/utils.R                                   42       0  100.00%
TOTAL                                     4899     124  97.47%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/tbl_null_report.R       +1       0  +100.00%
TOTAL                     +1       0  +0.00%

Results for commit: df9ce3c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files  236 suites   1m 22s ⏱️
237 tests 216 ✅ 21 💤 0 ❌
673 runs  623 ✅ 50 💤 0 ❌

Results for commit c09dd7e.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
add_forest	💀	$0.00$	$-0.00$	$-5$	$0$	$0$	$0$
add_grade_column	💀	$0.00$	$-0.00$	$-3$	$0$	$0$	$0$
df_add_poolings	💀	$0.00$	$-0.00$	$-5$	$0$	$0$	$0$
tbl_hierarchical_rate_and_count	💀	$0.00$	$-0.00$	$-2$	$0$	$0$	$0$
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	$-4$	$0$	$0$	$0$
tbl_roche_subgroups	💀	$0.00$	$-0.00$	$-2$	$0$	$0$	$0$
tbl_with_pools	💀	$0.00$	$-0.00$	$-1$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
add_blank_rows	👶		$+0.10$	unnamed
add_blank_rows	💚	$6.16$	$-1.40$	add_blank_rows_works
add_difference_row	💚	$3.88$	$-1.73$	add_difference_row.tbl_survfit_times_works
add_forest	💀	$0.00$	$-0.00$	add_forest_handles_extreme_limits_and_character_NA_p_values_safely
add_forest	💀	$0.02$	$-0.02$	add_forest_table_engine_flextable_works
add_grade_column	💀	$0.00$	$-0.00$	add_grade_column_blanks_stats_for_SOC_label_rows
add_grade_column	💀	$0.00$	$-0.00$	add_grade_column_errors_on_non_gtsummary_input
add_grade_column	💀	$0.00$	$-0.00$	add_grade_column_errors_when_custom_info_is_missing
add_grade_column	💀	$0.00$	$-0.00$	add_grade_column_extracts_custom_info_from_merged_tables
add_grade_column	💀	$0.00$	$-0.00$	add_grade_column_is_idempotent_when_called_twice
add_grade_column	💀	$0.00$	$-0.00$	add_grade_column_recodes_zero_statistics
add_grade_column	💀	$0.00$	$-0.00$	add_grade_column_sets_correct_header_labels
add_grade_column	💀	$17.28$	$-17.28$	add_grade_column_works_on_a_standalone_tbl_hierarchical_rate_by_grade
add_grade_column	💀	$0.00$	$-0.00$	add_grade_column_works_without_grade_groups
add_hierarchical_count_row	💚	$3.11$	$-2.70$	add_hierarchical_count_row_works
annotate_gg	💚	$5.90$	$-2.25$	annotate_lineplot_df_warns_if_plot_is_not_generated_by_gg_lineplot
annotate_gg_pkc	💚	$2.67$	$-2.66$	annotate_pkc_df_warns_when_given_a_standard_ggplot_object
check_formula_for_namespace	👶		$+0.03$	unnamed
df_add_poolings	💀	$0.00$	$-0.00$	df_add_poolings_accurately_subsets_when_keep_original_FALSE
df_add_poolings	💀	$0.00$	$-0.00$	df_add_poolings_correctly_stacks_original_and_pooled_rows
df_add_poolings	💀	$0.00$	$-0.00$	df_add_poolings_creates_a_total_dataset_when_all_is_passed
df_add_poolings	💀	$0.00$	$-0.00$	df_add_poolings_only_modifies_datasets_containing_the_arm_variable
df_add_poolings	💀	$0.00$	$-0.00$	df_add_poolings_processes_rlang_expr_correctly_across_datasets
df_add_poolings	💀	$0.00$	$-0.00$	df_add_poolings_safely_ignores_rlang_expr_evaluating_to_0_rows
df_add_poolings	💀	$0.00$	$-0.00$	df_add_poolings_triggers_appropriate_warnings
df_add_poolings	💀	$0.55$	$-0.55$	df_add_poolings_validates_inputs_and_throws_correct_cli_errors
gg_km	💔	$0.56$	$+1.66$	gg_km_works_and_handles_annotations_correctly
tbl_baseline_chg	👶		$+0.09$	unnamed
tbl_baseline_chg	💚	$18.43$	$-2.87$	tbl_baseline_chg_works
tbl_hierarchical_incidence_rate	💚	$18.78$	$-8.09$	tbl_hierarchical_incidence_rate_runs_with_minimum_arguments
tbl_hierarchical_rate_and_count	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_and_count_digits_styling_defaults_to_gtsummary
tbl_hierarchical_rate_and_count	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_and_count_emits_zero_rows_for_unobserved_factor_levels
tbl_hierarchical_rate_and_count	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_and_count_handles_0_row_data_with_factor_levels
tbl_hierarchical_rate_and_count	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_and_count_ignores_non_factor_variables
tbl_hierarchical_rate_and_count	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_and_count_sort_
tbl_hierarchical_rate_and_count	💀	$22.75$	$-22.75$	tbl_hierarchical_rate_and_count_works
tbl_hierarchical_rate_and_count	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_and_count_works_only_with_2_or_3_variables
tbl_hierarchical_rate_and_count	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_and_count_zero_rows_work_with_by_NULL
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_appends_missing_grade_group_levels_to_character_grade
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_error_messaging_works
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_filter_works
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_grade_groups_works_with_some_grades_not_in_groups
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_grade_groups_works_with_some_grades_not_in_groups_and_missing_grades
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_grades_exclude_works
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_include_overall_works
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_keep_zero_rows_works
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_sort_works
tbl_hierarchical_rate_by_grade	💀	$5.69$	$-5.69$	tbl_hierarchical_rate_by_grade_works
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_works_with_add_overall_
tbl_hierarchical_rate_by_grade	💀	$0.00$	$-0.00$	tbl_hierarchical_rate_by_grade_works_with_non_factor_grade_variables
tbl_rmpt	👶		$+0.03$	unnamed
tbl_rmpt	💚	$11.68$	$-1.97$	tbl_rmpt_works_with_default_parameters_Example_1_
tbl_roche_subgroups	💀	$10.15$	$-10.15$	tbl_roche_subgroups_time_to_event_NULL_works
tbl_roche_subgroups	💀	$0.00$	$-0.00$	tbl_roche_subgroups_time_to_event_works
tbl_shift	💚	$5.56$	$-3.06$	tbl_shift_strata_location_
tbl_survfit_quantiles	👶		$+0.05$	unnamed
tbl_survfit_quantiles	💔	$0.10$	$+2.36$	tbl_survfit_quantiles_works
tbl_survfit_times	💚	$2.88$	$-2.86$	tbl_survfit_times_works
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_add_grade_column_pipeline_does_not_duplicate_rows_226_
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_keep_original_FALSE_returns_only_the_pools
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_keeps_spanning_headers_set_by_the_inner_.tbl_fun_297_
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_passes_the_denominator_correctly_for_custom_functions
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_processes_rlang_expr_correctly_with_a_denominator
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_processes_rlang_expr_correctly_without_a_denominator
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_safely_handles_factor_columns_without_generating_NAs
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_skips_empty_data_pools_when_denominator_is_NULL
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_skips_if_an_rlang_expr_evaluates_to_0_rows
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_skips_pools_with_0_events_to_prevent_cards_engine_crash
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_skips_when_denominator_has_0_patients_but_data_has_0
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_suppresses_tidyselect_warnings_via_rlang_inject
tbl_with_pools	💀	$9.72$	$-9.72$	tbl_with_pools_validates_inputs_correctly
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_warns_and_skips_empty_pools_properly
tbl_with_pools	💀	$0.00$	$-0.00$	tbl_with_pools_works_with_standard_functions_like_tbl_summary

Results for commit ca7a2b3

♻️ This comment has been updated with latest results.

[mhallal1]

LGTM, thanks.