fix(rpc): support cometbft v1 validator updates - #70
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe RPC client now normalizes CometBFT v1 flattened validator public keys before CosmJS decoding. It also accepts nullable validator updates. Tests cover flattened keys, legacy nested keys, bigint voting power, and null updates. ChangesValidator update decoding
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change adds CometBFT v1 validator-key normalization and nullable-update handling with regression coverage; no merge-blocking risk is established. Sequence Diagram(s)sequenceDiagram
participant CometBFT
participant RPCClient
participant CosmJS
CometBFT->>RPCClient: Return block results with validator_updates
RPCClient->>RPCClient: Normalize flattened public-key fields
RPCClient->>CosmJS: Decode normalized validator updates
CosmJS-->>RPCClient: Return decoded public keys and voting power
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Summary by CodeRabbit