Skip to content

feat: support injective EthAccount chains in accountInfo - #69

Merged
traviolus merged 1 commit into
mainfrom
feat/injective-auth-api
Aug 31, 2026
Merged

feat: support injective EthAccount chains in accountInfo#69
traviolus merged 1 commit into
mainfrom
feat/injective-auth-api

Conversation

@traviolus

@traviolus traviolus commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added account information access through the REST client.
    • Added support for parsing both standard Cosmos account responses and Injective Ethermint-style account responses.
    • Account and sequence numbers are now handled consistently across supported response formats.
  • Bug Fixes

    • Improved wallet worker initialization to ensure account-related configuration is passed correctly.
  • Tests

    • Added coverage for standard and Ethermint-style account response parsing.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4adf5d4d-d8bd-4863-8458-8a08b17836bb

📥 Commits

Reviewing files that changed from the base of the PR and between 1ece3a3 and 51c229d.

📒 Files selected for processing (3)
  • src/lib/restClient.spec.ts
  • src/lib/restClient.ts
  • src/workers/walletSequence.spec.ts

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The REST client now exposes AuthAPI and parses standard Cosmos BaseAccount and Injective Ethermint-style EthAccount responses. Authentication tests cover both formats. The wallet sequence test updates WalletWorker construction.

Changes

REST authentication account information

Layer / File(s) Summary
AuthAPI account parsing
src/lib/restClient.ts, src/lib/restClient.spec.ts
RESTClient initializes public AuthAPI. accountInfo parses standard accounts and unwraps nested Injective EthAccount data. Tests verify account and sequence numbers.

Wallet worker test construction

Layer / File(s) Summary
WalletWorker constructor call
src/workers/walletSequence.spec.ts
The test worker factory passes an additional undefined argument before the options object.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 51c22

This localized change adds Injective account support without any identified correctness, security, availability, or deployment risk; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: beer-1

Poem

A rabbit found accounts in code,
With numbers parsed along the road.
Base and Ethermint now align,
While workers pass one extra sign.
Tests hop softly, green and bright.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: support for Injective EthAccount chains in accountInfo.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/injective-auth-api

Comment @coderabbitai help to get the list of available commands.

@traviolus
traviolus requested a review from Vritra4 August 31, 2026 09:15
@traviolus
traviolus merged commit 490fe1c into main Aug 31, 2026
5 checks passed
@traviolus
traviolus deleted the feat/injective-auth-api branch August 31, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants