Repository navigation
fix(cli): reuse vault connections across commands and sessions - #163
Merged
Merged
Conversation
nkavian
force-pushed
the
fix/vault-command-preparation
branch
2 times, most recently
from
October 10, 2026 04:19
5b5c32b to
8ba1265
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
nkavian
force-pushed
the
fix/vault-command-preparation
branch
from
October 10, 2026 04:32
8ba1265 to
21b7b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce repeated vault preparation and connection overhead in CLI commands and MCP sessions across macOS, Linux, and Windows.
Validation
Passed:
pnpm typecheck,pnpm lint,pnpm test,pnpm coverage:changed,pnpm typedoc,pnpm format:check,INFLOW_WEB_STAGING=0 pnpm build, andgit diff --check.Signed macOS and installed Linux/Windows candidates exercised connection reuse and credential lifecycle scenarios. Live command checks included discovery, OpenAPI operations, and existing AEP enrollment. The final OpenAPI correction was validated locally and against a live advertised document; it was not rebuilt into the Linux/Windows candidates.
Physical sleep/resume remains unverified. Successful TAP-signing timing and a matched token-refresh performance comparison were not measured. The AEP retry found an active enrollment, so it did not exercise approval cancellation.
Scope
Signed macOS packaging left the development CLI and native-module fingerprints unchanged; both builds ran afterward without a repair build. The packaged vault smoke passed, including tamper rejection.
Linux MCP lifecycle checks run against the installed package in CI, alongside the installed inspection checks. Development-mode runs retain the macOS checks.
No release or deployment. Hosted checks must pass before merge.