Skip to content

fix(cli): reuse vault connections across commands and sessions - #163

Merged
nkavian merged 1 commit into
inflowpayai:mainfrom
nkavian:fix/vault-command-preparation
Oct 10, 2026
Merged

nkavian merged 1 commit into
inflowpayai:mainfrom
nkavian:fix/vault-command-preparation

Conversation

@nkavian

@nkavian nkavian commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Reduce repeated vault preparation and connection overhead in CLI commands and MCP sessions across macOS, Linux, and Windows.

  • Reuse verified connections with bounded requests, explicit cleanup, and reconnect handling.
  • Preserve lock, logout, reset, and credential replacement behavior for retained clients.
  • Update the InFlow SDK dependencies and resolve saved API keys per request.
  • Use explicitly advertised OpenAPI URLs without probing conventional locations.
  • Build the signed macOS native module separately from development artifacts.

Validation

Passed: pnpm typecheck, pnpm lint, pnpm test, pnpm coverage:changed, pnpm typedoc, pnpm format:check, INFLOW_WEB_STAGING=0 pnpm build, and git diff --check.

Signed macOS and installed Linux/Windows candidates exercised connection reuse and credential lifecycle scenarios. Live command checks included discovery, OpenAPI operations, and existing AEP enrollment. The final OpenAPI correction was validated locally and against a live advertised document; it was not rebuilt into the Linux/Windows candidates.

Physical sleep/resume remains unverified. Successful TAP-signing timing and a matched token-refresh performance comparison were not measured. The AEP retry found an active enrollment, so it did not exercise approval cancellation.

Scope

Signed macOS packaging left the development CLI and native-module fingerprints unchanged; both builds ran afterward without a repair build. The packaged vault smoke passed, including tamper rejection.

Linux MCP lifecycle checks run against the installed package in CI, alongside the installed inspection checks. Development-mode runs retain the macOS checks.

No release or deployment. Hosted checks must pass before merge.

@nkavian
nkavian force-pushed the fix/vault-command-preparation branch 2 times, most recently from 5b5c32b to 8ba1265 Compare October 10, 2026 04:19
@nkavian
nkavian force-pushed the fix/vault-command-preparation branch from 8ba1265 to 21b7b52 Compare October 10, 2026 04:32
@nkavian
nkavian merged commit 49c500a into inflowpayai:main Oct 10, 2026
1 check passed
@nkavian
nkavian deleted the fix/vault-command-preparation branch October 10, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant