fix(reactotron-app): filter custom commands by connection - #1617
Open
giaBaoJS wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR
When multiple apps are connected, the Custom Commands context contains registrations from every client. The page previously searched, rendered, and calculated its empty state from that global list, so commands from other connections appeared as duplicates.
This change reads the active connection from
StandaloneContextand filters registrations byclientIdbefore applying search or rendering the empty state. Switching connections now immediately shows only that client's commands.Fixes #1601.
Test plan
yarn build-and-test:localreactotron-core-clientWebSocket connections: the page initially showed only the selected iOS command, switched to only the Android command, and dispatching it was received by the Android clientThe runtime check used real core clients rather than mobile simulators; it exercises the same
clientIdregistration and command-routing protocol without platform app binaries. No documentation changes are needed because this restores the existing selected-connection behavior.