fix(dsl): confine native read sources - #840
Open
rustytrees wants to merge 1 commit into
Open
Conversation
Open Pathname and inreplace sources through confined no-follow descriptors, then read from those descriptors. This prevents formula steps from importing bytes through direct outside paths or final-component symlinks.
Owner
|
@rustytrees Thanks for the contribution! One small request: could you please instruct your agent to follow the PR template provided in the repository for PRs? It helps keep the PRs consistent and easier to review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pathname.readand both nativeinreplacepaths now open sources through confined, no-follow descriptors. Reads stay bound to the checked object, so direct outside paths and final-component symlinks cannot import host-file bytes into the prefix.Regression tests cover direct Pathname reads, final symlink reads, DSL
inreplace, and declarativeinreplace.Related Issue
Closes #850.
Notes for Reviewers
Verification completed:
zig build test-one: 2,426 passedzig build test: 5,063 passed, 3 skippedgit verify-commit