Skip to content

fix(post-install): honour the conditions and fields formulas declare - #832

Merged
indaco merged 1 commit into
mainfrom
fix/post-install-honour-declarations
Aug 10, 2026
Merged

fix(post-install): honour the conditions and fields formulas declare#832
indaco merged 1 commit into
mainfrom
fix/post-install-honour-declarations

Conversation

@indaco

@indaco indaco commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Description

A step could carry an instruction the executor did not implement and still report success. Guards were the widest case: only three step types checked them, so a copy told to run only under a condition ran unconditionally and overwrote what the formula meant to keep. Guards now gate every step type, the unless_exists condition formulas use to protect existing user data is honoured, and a step carrying a field the executor cannot honour refuses loudly instead of doing partial work under a completed banner.

Seven more formulas now finish their post-install rather than warning: arcadedb, bareos-client, cayley, kafka, opensearch, rpm and tronbyt-server.

Related Issue

  • None

Notes for Reviewers

  • The refusal list names what each step honours rather than what it ignores, so a field upstream adds later is loud on arrival instead of silently dropped.
  • Checked against every formula in homebrew-core: the set that completes post-install grows from 104 to 111, and no formula loses one it completes today.

Base automatically changed from fix/node-post-install-steps to main August 10, 2026 17:11
@indaco
indaco force-pushed the fix/post-install-honour-declarations branch from cfaaa96 to fff1515 Compare August 10, 2026 17:11
@indaco
indaco force-pushed the fix/post-install-honour-declarations branch from fff1515 to e198db0 Compare August 10, 2026 17:11
@indaco
indaco merged commit e8681e9 into main Aug 10, 2026
3 checks passed
@indaco
indaco deleted the fix/post-install-honour-declarations branch August 10, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant