Skip to content

fix(ucode): don't double-encode ss:// node label - #662

Merged
1715173329 merged 1 commit into
immortalwrt:devfrom
AviderMin:master
Oct 1, 2026
Merged

1715173329 merged 1 commit into
immortalwrt:devfrom
AviderMin:master

Conversation

@AviderMin

Copy link
Copy Markdown
Contributor

urlencode on an already URL-encoded label turns %% into %%25, so labels like %%E9%%A6%%99%%E6%%B8%%AF... ended up double-encoded and displayed as raw percent-escaped text instead of the decoded name. Keep the raw label and let parseURL + urldecode handle decoding.

if (length(ss_suri) <= 2) {
if (length(ss_suri) === 2)
ss_slabel = '#' + urlencode(ss_suri[1]);
/* Keep the raw label; parseURL + urldecode will decode it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this useless comment

urlencode on an already URL-encoded label turns % into %25, so labels
like %E9%A6%99%E6%B8%AF... ended up double-encoded and displayed as
raw percent-escaped text instead of the decoded name. Keep the raw label
and let parseURL + urldecode handle decoding.
@1715173329
1715173329 merged commit 95f36f3 into immortalwrt:dev Oct 1, 2026
@1715173329

Copy link
Copy Markdown
Member

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants