Fix pacman updater package discovery - #1368
Closed
amandeepsp wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for the update. When this is ready for maintainer review, please remember to mark the pull request as ready for review instead of leaving it in draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-desktop-latest.pkg.tar.zstsymlink during artifact discoveryThe pacman builder intentionally writes both a versioned package and a stable
latestsymlink. The updater previously matched entries by filename alone, soit counted both paths and left Arch updates in
Failedwithexpected one rebuilt package, found 2.This keeps the existing exactly-one-artifact invariant while excluding aliases,
directories, and other non-regular entries from the candidate set.
Validation
cargo test -p codex-update-manager(50 passed)cargo clippy -p codex-update-manager --all-targets -- -D warningsgit diff --check26.810.52044package: rebuild,privileged pacman install, state transition to
Installed, and subsequentcheck settling to
Idlecargo fmt --all -- --checkwas also inspected, but current unmodifiedmainalready reports repository-wide formatting differences across updater files;
this PR does not broaden the diff to reformat them.
Checklist
CONTRIBUTING.md, kept the change focused, edited source files rather than generated output, and removed unrelated changes.