Skip to content

Align session search and actions with loaded state #9470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
james-chua-1493 wants to merge 6 commits into
base: master
Choose a base branch
from
+25 −6
Open

Align session search and actions with loaded state #9470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9af1284
Align session search and actions with loaded state
james-chua-1493 Aug 13, 2026
4276a60
Replace New Session button with ExpandCollapseButton and mute session…
james-chua-1493 Aug 14, 2026
5938a27
Apply suggestion from @jrjohnson
james-chua-1493 Aug 18, 2026
a04d538
Mute session action buttons with loading-text and fix header alignment
james-chua-1493 Aug 18, 2026
db28d31
Use plain button with icon instead of ExpandCollapseButton to fix tes…
james-chua-1493 Aug 20, 2026
386cd9d
Apply suggestion from @jrjohnson
james-chua-1493 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/ilios-common/addon/components/course/loading.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import BackToCourses from 'ilios-common/components/course/back-to-courses';
import animateLoading from 'ilios-common/modifiers/animate-loading';
import t from 'ember-intl/helpers/t';
import FaIcon from '@fortawesome/ember-fontawesome/components/fa-icon';
import { faSquarePlus } from '@fortawesome/free-solid-svg-icons';
import { faSquarePlus, faPlus } from '@fortawesome/free-solid-svg-icons';
<template>
<BackToCourses />

Expand Down Expand Up @@ -54,11 +54,18 @@ import { faSquarePlus } from '@fortawesome/free-solid-svg-icons';
{{t "general.sessions"}}
(xx)
</div>
<div class="actions"></div>
</div>
<div class="filter">
{{! template-lint-disable require-input-label }}
<input disabled />
<div class="actions">
<div class="filter">
{{! template-lint-disable require-input-label }}
<input disabled />
</div>
<button type="button" class="loading-text" disabled>
<FaIcon @icon={{faPlus}} />
</button>
<button type="button" class="loading-text" disabled>
{{t "general.publicationReview"}}
</button>
</div>
</div>
<section>
<div class="sessions-grid-row sessions-grid-header-row loading-text"></div>
Expand Down
12 changes: 12 additions & 0 deletions packages/ilios-common/app/styles/ilios-common/components/course/loading.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,21 @@

.course-sessions-header {
height: 2rem;
display: flex;
align-items: center;
justify-content: space-between;
@include m.for-phone-only {
height: 3rem;
}

.actions {
display: flex;
cursor: default;

.loading-text {
background-color: var(--lighter-grey);
}
}
}

.sessions-grid-header-row {
Expand Down