Skip to content

removes UI for managing curriculum inventory reports. - #9449

Merged
dartajax merged 2 commits into
ilios:masterfrom
stopfstedt:rm_curriculum_inventory_report_mangement_ui
Aug 14, 2026
Merged

removes UI for managing curriculum inventory reports.#9449
dartajax merged 2 commits into
ilios:masterfrom
stopfstedt:rm_curriculum_inventory_report_mangement_ui

Conversation

@stopfstedt

@stopfstedt stopfstedt commented Aug 4, 2026

Copy link
Copy Markdown
Member

fixes ilios/ilios#7301

this removes any curriculum inventory report management related code but models and associates (tests/serializers) from the frontend.

@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 4de2628
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6a7f39f2ed0b84000817d1dc
😎 Deploy Preview https://deploy-preview-9449--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

✅ Visual Diff Report — PASSED

984 images compared: 984 identical

Download the results.

@stopfstedt
stopfstedt force-pushed the rm_curriculum_inventory_report_mangement_ui branch 2 times, most recently from c792b2a to 7dfa884 Compare August 4, 2026 16:30
@stopfstedt
stopfstedt marked this pull request as ready for review August 4, 2026 20:19
@stopfstedt
stopfstedt force-pushed the rm_curriculum_inventory_report_mangement_ui branch from 7dfa884 to 5e1d38e Compare August 4, 2026 20:23
@stopfstedt
stopfstedt marked this pull request as draft August 4, 2026 20:23
@stopfstedt
stopfstedt marked this pull request as ready for review August 4, 2026 20:46

@michaelchadwick michaelchadwick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some more instances of CIR that should probably be taken out:

rg -w "curriculum inventory"
packages/frontend/translations/en-us.yaml
47:  canNotDeleteProgram: This program cannot be deleted because it is attached to a curriculum inventory report or program year, or you do not have permission.

packages/frontend/tests/acceptance/four-oh-four-test.js
134:  test('visiting missing curriculum inventory report #6324', async function (assert) {

packages/test-app/tests/unit/serializers/curriculum-inventory-export-test.js
4:module('Unit | Serializer | curriculum inventory export', function (hooks) {

packages/test-app/tests/unit/serializers/curriculum-inventory-report-test.js
4:module('Unit | Serializer | curriculum inventory report', function (hooks) {

packages/test-app/tests/unit/serializers/curriculum-inventory-sequence-block-test.js
4:module('Unit | Serializer | curriculum inventory sequence block', function (hooks) {

That first one should probably change from canNotDeleteProgram: This program cannot be deleted because it is attached to a curriculum inventory report or program year, or you do not have permission. to canNotDeleteProgram: This program cannot be deleted because it is attached to a program year, or you do not have permission.

@stopfstedt

Copy link
Copy Markdown
Member Author

I found some more instances of CIR that should probably be taken out:

rg -w "curriculum inventory"
packages/frontend/translations/en-us.yaml
47:  canNotDeleteProgram: This program cannot be deleted because it is attached to a curriculum inventory report or program year, or you do not have permission.

packages/frontend/tests/acceptance/four-oh-four-test.js
134:  test('visiting missing curriculum inventory report #6324', async function (assert) {

packages/test-app/tests/unit/serializers/curriculum-inventory-export-test.js
4:module('Unit | Serializer | curriculum inventory export', function (hooks) {

packages/test-app/tests/unit/serializers/curriculum-inventory-report-test.js
4:module('Unit | Serializer | curriculum inventory report', function (hooks) {

packages/test-app/tests/unit/serializers/curriculum-inventory-sequence-block-test.js
4:module('Unit | Serializer | curriculum inventory sequence block', function (hooks) {

That first one should probably change from canNotDeleteProgram: This program cannot be deleted because it is attached to a curriculum inventory report or program year, or you do not have permission. to canNotDeleteProgram: This program cannot be deleted because it is attached to a program year, or you do not have permission.

interesting point. the given reason as stated will still hold true - we're keeping the CIR data and its relationships around. might need to defer to Sascha on this.

@michaelchadwick

Copy link
Copy Markdown
Contributor

@stopfstedt

this removes any curriculum inventory report management related code but models and associates (tests/serializers) from the frontend.

Oops, missed that part. Didn't realize we were not going scorched earth. So, not sure now.

@stopfstedt stopfstedt added DO NOT MERGE Needs Team Discussion safe to deploy mark as from a trusted source and OK to deploy labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Staging build deployed! It can be accessed with bin/console ilios:update-frontend --staging-build --at-version=pr_preview-9449

2 similar comments
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Staging build deployed! It can be accessed with bin/console ilios:update-frontend --staging-build --at-version=pr_preview-9449

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Staging build deployed! It can be accessed with bin/console ilios:update-frontend --staging-build --at-version=pr_preview-9449

@stopfstedt
stopfstedt dismissed michaelchadwick’s stale review August 4, 2026 23:40

see comment thread.

@stopfstedt
stopfstedt force-pushed the rm_curriculum_inventory_report_mangement_ui branch from 5e1d38e to c356121 Compare August 14, 2026 15:14
this makes the tooltip a bit less precise, but at least it doesn't
explicitly reference data points that aren't accessible through the UI.
@stopfstedt

Copy link
Copy Markdown
Member Author

I found some more instances of CIR that should probably be taken out:
...
That first one should probably change from canNotDeleteProgram: This program cannot be deleted because it is attached to a curriculum inventory report or program year, or you do not have permission. to canNotDeleteProgram: This program cannot be deleted because it is attached to a program year, or you do not have permission.

interesting point. the given reason as stated will still hold true - we're keeping the CIR data and its relationships around. might need to defer to Sascha on this.

we discussed this with Sascha during yesterday's standup. I updated the tooltip with the verbiage that he suggested.

@michaelchadwick
michaelchadwick self-requested a review August 14, 2026 16:34

@michaelchadwick michaelchadwick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You fixed the stuff I brought up, so approved

@dartajax
dartajax merged commit bf657a3 into ilios:master Aug 14, 2026
67 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to deploy mark as from a trusted source and OK to deploy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Curriculum Inventory Components

3 participants