Repository navigation
feat(nameresolving): bound and expand composed DNS multiaddresses - #3385
Draft
richard-ramos wants to merge 2 commits into
Draft
richard-ramos wants to merge 2 commits into
richard-ramos wants to merge 2 commits into
Conversation
This was referenced Nov 4, 2026
richard-ramos
force-pushed
the
feat/dns-multiaddress-expansion
branch
from
November 4, 2026 13:44
f045b26 to
ec303b1
Compare
richard-ramos
force-pushed
the
feat/dns-multiaddress-expansion
branch
2 times, most recently
from
November 4, 2026 13:47
59ff3f1 to
5785260
Compare
Collaborator
Author
|
/review |
Contributor
|
🔍 OpenCodeReview found 6 issue(s) in this PR.
Model: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
richard-ramos
force-pushed
the
feat/dns-multiaddress-expansion
branch
2 times, most recently
from
November 4, 2026 14:44
164c574 to
31cec7e
Compare
richard-ramos
force-pushed
the
feat/dns-multiaddress-expansion
branch
from
November 5, 2026 22:57
31a68f1 to
07dc2d8
Compare
richard-ramos
force-pushed
the
feat/dns-multiaddress-expansion
branch
from
November 5, 2026 23:07
07dc2d8 to
8d18ccb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve DNS components anywhere in a multiaddress while preserving surrounding protocols, including addresses without a transport port. Hostname extraction prefers DNS names beyond prefixes so dialing retains the intended hostname.
Match DNSADDR suffixes exactly, skip malformed TXT records, and deduplicate results. During dialing, prune records for other peers before recursion and compare transport suffixes without the terminal expected peer ID. Intermediate and final records may omit the peer ID.
One expansion routine shares lookup and output budgets across branches, detects cycles, and permits a shorter path to revisit an address previously limited by depth. Tests cover composed addresses, suffix matching, limits, cancellation, and ranked/sequential dialing.
Impact on Library Users
Each resolution call permits at most 32 lookups, four DNSADDR levels, and 100 output addresses. Each response expands at most 16 matching DNSADDR records or examines at most 100 IP records. Malformed records and records rejected by peer or suffix checks do not consume the DNSADDR expansion budget. Results retain answer order; branches beyond the limits are omitted with trace diagnostics.
Stack
3 of 3 — merge in this order:
master.feat/system-name-resolver.feat/system-resolver-backend.All three PRs are drafts. Review this diff against its parent branch.
Validation
Before restacking: expansion suite, 14 checks passed; existing name-resolution suite, 11 checks passed. After restacking: dialer suite, 44 checks passed. The rebase preserves expansion behavior and removes the obsolete base resolver lifecycle hooks.
References
Builds on the multiaddress work proposed in #3114. Suffix matching follows the DNSADDR specification.