Functor and Applicative laws for core library types - #3850
Closed
joelberkeley wants to merge 2 commits into
Closed
joelberkeley wants to merge 2 commits into
joelberkeley wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The functor and applicative laws for common library types. I am missing some applicative laws for list/snoclist, cos they're non-trivial. I could also add monad laws. I don't know if I'll get round to them (let's assume not). Laws from here https://en.wikibooks.org/wiki/Haskell/Applicative_functors. PLEASE CORRECT ME IF I'VE INTERPRETED THEM WRONG.
This is a draft to get opinions before I invest effort needlessly.
It's quite unclear what types make sense to implement these for. I originally asked about Prelude types, which doesn't include
Vect. Unfussed if we include that or not. It's quite hard to know where the line is (what about List1, State etc.).Could do just the functor laws for now - they're always easy.
Self-check
CONTRIBUTING.mdand I've updated
CONTRIBUTORSwith my name.implementation, I have updated
CHANGELOG_NEXT.md