🐛 PUT programs/{shortName} Does not update database with changes

[joneubank]

Describe the bug

Requests sent to update programs are being returned with 200OK and no content, and the updates provided in the request are not saved.

This request should be returning 200OK with the updated program information.

If there is a problem with the request an appropriate error response should be returned.

Steps To Reproduce

Steps to reproduce the behaviour:

1. Send request to PUT programs/{shortName} with a copy of the existing program data as the request body but the description is changed.
2. receive response of 200OK with no content
3. Send request to GET programs/{shortName}
4. receive response of the program but the updates are not present

Expected behaviour

The PUT request should be returning 200OK with the updated program information.

Some fields should not be able to be updated:

• data center
• membership type
• shortName

[demariadaniel]

Chatted w/ @Azher2Ali, just clarifying that we don't technically have a PUT programs/{shortName} endpoint, simply use PUT programs

[demariadaniel]

Bug analysis from @Azher2Ali:
The mapping between proto generated files and REST pojo's are failing on MembershipType enum.
In order to fix this we need to write custom mapping and used that for transformation between the two.
Currently we are using the Object Mapper which is failing
We can write manual mapping in order to get this resolved

[joneubank]

Fixed in current edge release: 817eee0. A release and deploy is needed to close this.

[joneubank]

Fixed in 1.17.4. Released to QA.