Conversation
tmadlener
reviewed
Sep 22, 2026
tmadlener
left a comment
Contributor
There was a problem hiding this comment.
Wondering whether we could solve at least some of these issues by not re-implementing half of the root dictionary generation here, but rather using the one that comes with ROOT now.
CI seems to have been happy before as well. Did we not catch this due to not testing the env / stack where this happens, or because we have no test for this at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LCIO's ROOT dictionaries currently record source-tree relative header paths such as
include/IMPL/LCCollectionVec.h. Installed views expose<view>/includethroughROOT_INCLUDE_PATH, so ROOT cannot resolve thosepaths and
import pyLCIOfails when the Python ownership decorators accessLCCollectionVec::addElement.Normalize dictionary header paths relative to
ROOT_DICT_INCLUDE_DIRSbefore passing them torootcint. Keep LinkDefdefined_inpragmas and CMake dependencies on the original absolute paths, becauserootcintuses themto generate class registrations.
BEGINRELEASENOTES
ENDRELEASENOTES
Issue uncovered by iLCSoft/LCIO#226. Importing pyLCIO in a view without
include/IMPLinROOT_INCLUDE_PATHfails: