Skip to content

Link to streamlog instead of Marlin_LIBRARIES #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmcarcell wants to merge 2 commits into from
Closed

Link to streamlog instead of Marlin_LIBRARIES #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd08e11
Link to streamlog instead of Marlin_LIBRARIES
jmcarcell Aug 22, 2024
fa24b97
Try
jmcarcell Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ INCLUDE( ilcsoft_default_settings )

FIND_PACKAGE( Marlin 1.0 REQUIRED ) # minimum required Marlin version
INCLUDE_DIRECTORIES( ${Marlin_INCLUDE_DIRS} )
Comment on lines 26 to 27

@tmadlener tmadlener Aug 22, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to find Marlin if we only want streamlog?

@jmcarcell jmcarcell Aug 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some includes that need Marlin:
https://github.com/iLCSoft/KiTrack/blob/master/include/KiTrack/SubsetSimple.h#L6 so it should be needed?

LINK_LIBRARIES( ${Marlin_LIBRARIES} )
LINK_LIBRARIES( streamlog::streamlog )
ADD_DEFINITIONS( ${Marlin_DEFINITIONS} )


Expand Down
Loading