P0: fix(auth): preserve the request URI in recovery links - #218
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: 79ca2e2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚅 Deployed to the ePDS-pr-218 environment in ePDS
|
Coverage Report for CI Build 30561185967Coverage remained the same at 57.281%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
9ad8954 to
a193589
Compare
This comment has been minimized.
This comment has been minimized.
a193589 to
b9bfa78
Compare
b9bfa78 to
79ca2e2
Compare
|



Summary
Carry the active PAR
request_uriinto account recovery instead of using a placeholder. Successful recovery can then return the user to the authorization request that initiated sign-in.Changes
Testing
pnpm format:checkpnpm lintpnpm typecheckpnpm testpnpm test:coverageBefore/after evidence
Before: the recovery link used a placeholder
request_uri. Clicking Back to sign in therefore could not return to the active authorization request or restore its OTP form.After: the browser scenario now captures the live
request_uri, follows the recovery link, clicks Back to sign in, verifies the same URI is restored, and asserts that a usable sign-in form is visible instead of an OAuth error. This is a navigation/state fix with no meaningful static visual difference; the complete behavioral round trip is covered inaccount-recovery.feature.Notes
The earlier PR-attached E2E attempt could not find the delayed deployment for the final amendment. After Railway recovered, the required check was rerun and the current SHA passed the full deployed suite in run 30561186061.
Current-branch deployed E2E: run 30561478453.
Focused extraction and review of work originally proposed in [WIP] many usability fixes (needs untangling) #165.
The deployed E2E suite passed.