ci: build docker images on push to main/development - #677
Merged
Conversation
… PRs pull_request[closed] only fires for PRs merged via GitHub, so direct pushes and locally-merged pushes to development never rebuilt hummingbot/gateway:development. Push triggers cover both cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Greptile SummaryThe workflow now builds Docker images on pushes to the release branches rather than only after merged pull requests.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| .github/workflows/docker_buildx_workflow.yml | Replaces the merged-pull-request build trigger with branch pushes and updates image-step conditions to inspect the pushed ref. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
P[Push event] --> B{Branch}
B -->|main| L[Build and push latest image]
B -->|development| D[Build and push development image]
B -->|core-2.6| N[No image build step]
R[Release published or edited] --> V[Build and push versioned image]
Reviews (2): Last reviewed commit: "Merge branch 'development' into ci/docke..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request: types: [closed](merged-PR only) topushonmain/development/core-2.6.developmentnow also rebuildhummingbot/gateway:developmentautomatically.github.base_ref(only set on PR events) togithub.ref.Test plan
developmentand confirm the "Gateway Docker Buildx Workflow" run builds and pusheshummingbot/gateway:development.🤖 Generated with Claude Code