Skip to content

ci: build docker images on push to main/development - #677

Merged
fengtality merged 2 commits into
developmentfrom
ci/docker-build-on-push
Aug 11, 2026
Merged

ci: build docker images on push to main/development#677
fengtality merged 2 commits into
developmentfrom
ci/docker-build-on-push

Conversation

@fengtality

Copy link
Copy Markdown
Contributor

Summary

  • Switch the docker buildx workflow trigger from pull_request: types: [closed] (merged-PR only) to push on main / development / core-2.6.
  • Merged PRs already produce a push event on the base branch, so PR-merge builds keep working; direct pushes and locally-merged pushes to development now also rebuild hummingbot/gateway:development automatically.
  • Step conditions updated from github.base_ref (only set on PR events) to github.ref.

Test plan

  • After merge, push a commit to development and confirm the "Gateway Docker Buildx Workflow" run builds and pushes hummingbot/gateway:development.

🤖 Generated with Claude Code

… PRs

pull_request[closed] only fires for PRs merged via GitHub, so direct
pushes and locally-merged pushes to development never rebuilt
hummingbot/gateway:development. Push triggers cover both cases.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown

Greptile Summary

The workflow now builds Docker images on pushes to the release branches rather than only after merged pull requests.

  • Triggers builds for pushes to main, development, and core-2.6.
  • Uses branch refs to select the latest and development image tags.
  • Retains the existing release-image workflow.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/docker_buildx_workflow.yml Replaces the merged-pull-request build trigger with branch pushes and updates image-step conditions to inspect the pushed ref.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  P[Push event] --> B{Branch}
  B -->|main| L[Build and push latest image]
  B -->|development| D[Build and push development image]
  B -->|core-2.6| N[No image build step]
  R[Release published or edited] --> V[Build and push versioned image]
Loading

Reviews (2): Last reviewed commit: "Merge branch 'development' into ci/docke..." | Re-trigger Greptile

@fengtality
fengtality merged commit 3b06c07 into development Aug 11, 2026
4 checks passed
@fengtality
fengtality deleted the ci/docker-build-on-push branch August 11, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant