Skip to content

fix: recover polygon area from GeometryCollection intersections in grid trim #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dulcetberg wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: recover polygon area from GeometryCollection intersections in grid trim #7319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions backend/services/grid/grid_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,23 @@ def trim_grid_to_aoi(grid_dto: GridDTO) -> geojson.FeatureCollection:
intersecting_features.append(feature)
else:
intersection = aoi_multi_polygon.intersection(tile)
if intersection.is_empty or intersection.geom_type not in [
"Polygon",
"MultiPolygon",
]:
continue # this intersections which are not polygons or which are completely outside aoi
if intersection.is_empty:
continue # tile is completely outside aoi
if intersection.geom_type == "GeometryCollection":
# A tile touching the AOI boundary can intersect into a mix of
# geometry types (e.g. a real polygon slice plus stray points/
# lines from the boundary touch). Recover the polygon area
# instead of discarding the whole tile.
polygonal_parts = [
geom
for geom in intersection.geoms
if geom.geom_type in ("Polygon", "MultiPolygon")
]
if not polygonal_parts:
continue # no actual area in the intersection, nothing to keep
intersection = unary_union(polygonal_parts)
elif intersection.geom_type not in ["Polygon", "MultiPolygon"]:
continue # intersection is a bare LineString/Point, no area
# tile is partially intersecting the aoi
clipped_feature = GridService._update_feature(
clip_to_aoi, feature, intersection
Expand Down