Skip to content

Use project hashtag in OSMCha project filters - #7276

Open
nathanpixodeo wants to merge 1 commit into
hotosm:developfrom
nathanpixodeo:bugfix/7223-osmcha-project-hashtag-filter
Open

Use project hashtag in OSMCha project filters#7276
nathanpixodeo wants to merge 1 commit into
hotosm:developfrom
nathanpixodeo:bugfix/7223-osmcha-project-hashtag-filter

Conversation

@nathanpixodeo

Copy link
Copy Markdown

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation
  • Refactor
  • Test
  • Build or CI
  • Other (please specify)

Related Issue

Fixes #7223

Describe this PR

Updates the OSMCha link formatter so project-level links filter by the default project hashtag, e.g. #hotosm-project-46866, instead of the full changeset comment. This keeps project OSMCha links inclusive when mappers adjust the rest of the comment text for the features they actually edited.

If the project hashtag cannot be found, the formatter falls back to the existing full-comment filter behavior.

Screenshots

Not applicable; this changes generated link query parameters.

Alternative Approaches Considered

I considered changing only the project detail button component, but the same project-level OSMCha button is reused in other project views. Keeping the behavior in the shared formatter keeps those project links consistent while preserving the existing full-comment behavior for task/user-specific links.

Review Guide

Run:

cd frontend
node_modules/.bin/craco.cmd test --env=jsdom --watchAll=false --testMatch **/src/utils/tests/osmchaLink.test.js
node_modules/.bin/prettier.cmd --check src/utils/osmchaLink.js src/utils/tests/osmchaLink.test.js
yarn lint --quiet src/utils/osmchaLink.js src/utils/tests/osmchaLink.test.js

Verified locally on Windows. The default CRA/Jest absolute testMatch generated for this checkout did not match under .openclaw, so the targeted test command above passes an explicit --testMatch.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@sonarqubecloud

Copy link
Copy Markdown

@nathanpixodeo

Copy link
Copy Markdown
Author

Hi maintainers, quick follow-up on this PR. The checks are green and I do not see any open review feedback. Could someone please review/approve when available? If anything else is needed, happy to update. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change link behind "Changesets in OSMCha" button on project page

1 participant