Use project hashtag in OSMCha project filters - #7276
Open
nathanpixodeo wants to merge 1 commit into
Open
Conversation
|
Author
|
Hi maintainers, quick follow-up on this PR. The checks are green and I do not see any open review feedback. Could someone please review/approve when available? If anything else is needed, happy to update. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What type of PR is this? (check all applicable)
Related Issue
Fixes #7223
Describe this PR
Updates the OSMCha link formatter so project-level links filter by the default project hashtag, e.g.
#hotosm-project-46866, instead of the full changeset comment. This keeps project OSMCha links inclusive when mappers adjust the rest of the comment text for the features they actually edited.If the project hashtag cannot be found, the formatter falls back to the existing full-comment filter behavior.
Screenshots
Not applicable; this changes generated link query parameters.
Alternative Approaches Considered
I considered changing only the project detail button component, but the same project-level OSMCha button is reused in other project views. Keeping the behavior in the shared formatter keeps those project links consistent while preserving the existing full-comment behavior for task/user-specific links.
Review Guide
Run:
Verified locally on Windows. The default CRA/Jest absolute
testMatchgenerated for this checkout did not match under.openclaw, so the targeted test command above passes an explicit--testMatch.Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?