Skip to content

chore(frontend): migrate to TypeScript and Vite - #6534

Merged
spwoodcock merged 55 commits into
hotosm:typescript-vitefrom
JoltCode:typescript-vite
Jan 8, 2025
Merged

chore(frontend): migrate to TypeScript and Vite#6534
spwoodcock merged 55 commits into
hotosm:typescript-vitefrom
JoltCode:typescript-vite

Conversation

@JoltCode

Copy link
Copy Markdown

What type of PR is this? (check all applicable)

  • 📝 Documentation
  • 🧑‍💻 Refactor
  • 🤖 Build or CI

Related Issue

Fixes #6533
Fixed #6531

Describe this PR

A brief description of how this solves the issue.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file scope: frontend labels Aug 20, 2024
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@royallsilwallz

Copy link
Copy Markdown
Contributor

hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete?
cc - @htulipe @ramyaragupathy @manjitapandey

@JoltCode

Copy link
Copy Markdown
Author

hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete? cc - @htulipe @ramyaragupathy @manjitapandey

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

Feel free to shoot me a DM on Slack as well! 😄

@royallsilwallz

Copy link
Copy Markdown
Contributor

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?

@JoltCode

Copy link
Copy Markdown
Author

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?

Yeah it is a pretty hefty task! Sure, I'd be more than happy to call and discuss! 👍

@spwoodcock

Copy link
Copy Markdown
Member

We had a call about this just now @royallsilwallz

The initial requirement to get this done quickly has passed, as we managed a workaround / fix for the PR that was dependent on this.

As this is such a big undertaking, it makes sense to subdivide into smaller PRs.

Near term goals:

  • Fix merge conflicts here.
  • Wrap up the changes in this PR.
  • Ensure all frontend tests pass and Github workflows are happy.
  • Test changes in this PR from the whole team (perhaps even community testing).

Long term goals:

  • Continue where this PR left off.
  • Make subsequent PRs upgrading JS --> TS incrementally.

@03xb7

03xb7 commented Dec 6, 2024

Copy link
Copy Markdown

Let me know if I can give an hand on that

@spwoodcock

spwoodcock commented Dec 13, 2024

Copy link
Copy Markdown
Member

Thanks for the offer @htulipe !

Are you on the HOTOSM Slack by the way?
It might be easier to coordinate in a group chat 🙏

@JoltCode
JoltCode marked this pull request as ready for review December 28, 2024 18:59

@JoltCode JoltCode left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@spwoodcock spwoodcock added priority: low status: testing Does it really work or is it pretending to work? dev-setup 🛠️ labels Jan 7, 2025
@spwoodcock

Copy link
Copy Markdown
Member

We have the greenlight to test this branch on the dev server.

The line here needs to be modified: https://github.com/hotosm/tasking-manager/blob/develop/.circleci/config.yml#L456C22-L456C43

Then the branch will deploy for testing

@spwoodcock
spwoodcock changed the base branch from develop to typescript-vite January 8, 2025 10:48
@sonarqubecloud

sonarqubecloud Bot commented Jan 8, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
21 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@spwoodcock
spwoodcock merged commit a1c65b9 into hotosm:typescript-vite Jan 8, 2025
@royallsilwallz

royallsilwallz commented Feb 9, 2025

Copy link
Copy Markdown
Contributor

Continued with #6715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file dev-setup 🛠️ priority: low scope: frontend scope: infrastructure status: testing Does it really work or is it pretending to work?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from JavaScript --> TypeScript Replace craco / webpack frontend module bundler with vite

4 participants