Document that name_prefix must be unique per module call (per AZ) - #8
Merged
Merged
Conversation
The README's multi-AZ guidance implied that a second module call only needed a different public_subnet_id/private_route_table_ids. But the Lambda function names, CloudWatch Log Group names, and CloudWatch alarm names are all derived directly from name_prefix -- unlike the ASG/IAM role/EventBridge rule, which get Terraform's own randomized name_prefix suffix -- so two calls sharing the same prefix collide. This module deliberately has no multi-AZ logic of its own (non-goal), so a naming-scheme change to auto-derive uniqueness was out of scope; documenting the constraint in both README.md and the variable's own description is the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public_subnet_id/private_route_table_ids. But the Lambda function names, CloudWatch Log Group names, and CloudWatch alarm names are all derived directly fromname_prefix-- unlike the ASG/IAM role/EventBridge rule, which get Terraform's own randomizedname_prefixsuffix -- so two calls sharing the same prefix collide.README.mdand the variable's own description instead.Test plan
terraform fmt -recursive -diff(no diff)terraform validate(module root andexamples/basic)