fix: avoid mutating YAML nodes in-place when FormatStrings is enabled - #677
Open
TvdW wants to merge 1 commit into
Open
fix: avoid mutating YAML nodes in-place when FormatStrings is enabled#677TvdW wants to merge 1 commit into
TvdW wants to merge 1 commit into
Conversation
FormatStrings was modifying scalar node values directly on the caller's nodes, which corrupted the toNames slice collected after the comparison loop in namedEntryLists. This caused false order-change diffs when comparing identical named-entry lists. Fix by copying the nodes before modifying their Value fields so the originals remain unmodified for the rest of the comparison pipeline. Fixes issue homeport#676
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormatStrings was modifying scalar node values directly on the caller's nodes, which corrupted the toNames slice collected after the comparison loop in namedEntryLists. This caused false order-change diffs when comparing identical named-entry lists.
Fix by copying the nodes before modifying their Value fields so the originals remain unmodified for the rest of the comparison pipeline.
Fixes issue #676