simuluate git diff output - #221
Open
williamjoy wants to merge 4 commits into
Open
Conversation
added 3 commits
April 28, 2022 14:23
- accepts all arguments passed from git - generate similar diff context like built-in git diff - omit dyff header when running as external git diff tool - set GIT_CONFIG_PARAMETERS="'color.ui=always'" to enable colors
checking with KUBECTL_EXTERNAL_DIFF env variable this will be running in all cases even not running kubectl diff command
move arg[1], arg[2] to the end of argument list
Member
|
I am sorry, but I was very busy lately, but I am working through my backlog now. This PR will come next. |
Member
|
I had a look already. For PRs like these, I tend to play around with the problem a bit to get a better feeling. |
|
Hi @HeavyWombat Do you have any thoughts on whether or not this PR would be accepted & merged? I would like to use dyff with git but the lack of file names in the output makes it difficult when there are multiple changed files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code mostly copied from
dyff between, trying to resolve #189Tested with
GIT_CONFIG_PARAMETERS="'color.ui=always'" git log --ext-diff -p '**/*.yml'in current repo:Example output (and limitations)