Allow the watchdog to continue restarting an app indefinitely - #7062
Draft
puddly wants to merge 1 commit into
Draft
Allow the watchdog to continue restarting an app indefinitely#7062puddly wants to merge 1 commit into
puddly wants to merge 1 commit into
Conversation
Member
|
I don't like having an unbounded retry, some apps download something during startup, this can load infrastructure if instances are left unmaintained with apps in the watchdog loop. There is probably also a better alternative: Supervisor nowadays also takes Docker health check into account. It might be the better option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR introduces
watchdog_restart_policy, defaulting torate_limited. Settingwatchdog_restart_policy: unlimitedfor an app allows Supervisor to continue restarting the app indefinitely.This is useful for OTBR and Ziggurat (and others), since they provide interfaces to hardware that Home Assistant expects to exist at all times. Otherwise, the app will just be in a stopped state even if the watchdog is enabled, which (in my opinion) somewhat contradicts the purpose of a watchdog.
Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed: