Skip to content

Add notification_icon_color to supported keys on Android - #328

Merged
jpelgrom merged 1 commit into
home-assistant:mainfrom
inukiwi:android_notification_icon_color
Jun 29, 2026
Merged

Add notification_icon_color to supported keys on Android#328
jpelgrom merged 1 commit into
home-assistant:mainfrom
inukiwi:android_notification_icon_color

Conversation

@inukiwi

@inukiwi inukiwi commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

PR to accompany the change in home-assistant/android#7091

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Android v1 FCM payload builder to support the new notification_icon_color data key, aligning this service with the companion Android app change that treats notification_icon_color as the preferred alias for color.

Changes:

  • Add notification_icon_color to the allowlist of Android notification-related data keys forwarded into the FCM data payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread functions/android.js
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.43%. Comparing base (5615e56) to head (c5c85c6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          10       10           
  Lines         642      642           
  Branches      207      207           
=======================================
  Hits          510      510           
  Misses        113      113           
  Partials       19       19           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jpelgrom jpelgrom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android PR is merged

@jpelgrom
jpelgrom merged commit 318b32e into home-assistant:main Jun 29, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants