Progress bar customization by inukiwi · Pull Request #6527 · home-assistant/android

inukiwi · 2026-03-03T14:01:09Z

Summary

This feature adds support for progress bar customization on Android 16.0+ devices, as shown here.

Checklist

New or updated tests have been added to cover the changes following the testing guidelines.
The code follows the project's code style and best_practices.
The changes have been thoroughly tested, and edge cases have been considered.
Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Screenshots

Link to pull request in documentation repositories

User Documentation: home-assistant/companion.home-assistant#1297

Any other notes

Copilot

Pull request overview

Adds support for Android 16+ “progress-centric” notification customization in the Android Companion App notification pipeline, enabling richer progress rendering (segments/points and custom icons) when notifications are received from Home Assistant.

Changes:

Added parsing helper (parseFlattenedList) to interpret flattened list payloads (e.g., from WebSocket-flattened notification data)
Added Android 16+ NotificationCompat.ProgressStyle handling for segments, points, and tracker/start/end icons
Introduced new notification data keys for progress customization (progress_segments, progress_points, progress_*_icon, progress_*_color)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
common/src/main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt	Adds helper to parse flattened list strings into structured key/value maps for progress style inputs
app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt	Applies Android 16+ progress-centric `ProgressStyle` based on new notification payload keys

You can also share your feedback on Copilot code review. Take the survey.

TimoPtr · 2026-03-23T13:52:03Z

+                sizeDp = 20
+                colorFilter = PorterDuffColorFilter(progressTrackerColor, PorterDuff.Mode.SRC_IN)
+                backgroundColorRes = accentColor
+                roundedCornersDp = 10
+                paddingDp = 4
+            }


I would like some docs about the choice of these magic numbers.

TimoPtr · 2026-03-23T13:52:19Z

+        if (progressStartIcon.startsWith("mdi:") && progressStartIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressStartIcon.split(":")[1]
+            val iconDrawable = IconicsDrawable(context, "cmd-$iconName").apply {
+                sizeDp = 20


same here or even a const

TimoPtr · 2026-03-23T13:52:23Z

+        if (progressEndIcon.startsWith("mdi:") && progressEndIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressEndIcon.split(":")[1]
+            val iconDrawable = IconicsDrawable(context, "cmd-$iconName").apply {
+                sizeDp = 20


same here or even a const

TimoPtr · 2026-03-23T13:59:35Z

+        if (progressStartIcon.startsWith("mdi:") && progressStartIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressStartIcon.split(":")[1]


same and could actually be wrap into a small helper

TimoPtr · 2026-03-23T13:59:47Z

+        if (progressEndIcon.startsWith("mdi:") && progressEndIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressEndIcon.split(":")[1]


github-advanced-security

ktlint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

inukiwi · 2026-06-17T15:39:18Z

This also requires PR home-assistant/mobile-apps-fcm-push#317 to support objects in notification data

TimoPtr · 2026-06-18T14:11:40Z

        // Values for temporarily added keys
        const val THIS_SERVER_ID = "server_id"
+
+        private val lenientJson = Json { isLenient = true }


It's a one time thing, we should not make this available too broadly because whenever we want to parse a JSON we should use our existing instance kotlinJsonMapper

TimoPtr · 2026-06-18T14:17:34Z

+        val segmentsData = data[PROGRESS_SEGMENTS] ?: ""
+        if (segmentsData.isNotBlank()) {
+            try {
+                val segments: List<Map<String, String>> = lenientJson.decodeFromString(segmentsData)


Did you try if it works with our current parser? I would really like to use it instead of this one. Where is the quote removed from the key that we have to do that? If it's from our code can we avoid this?

TimoPtr · 2026-06-18T14:18:13Z

+                if (segments.isNotEmpty()) {
+                    return true
+                }
+            } catch (e: kotlinx.serialization.SerializationException) {


Make an import and update all try/catch in the file

TimoPtr · 2026-06-18T14:19:12Z

+        iconString: String,
+        iconColor: Int,
+        backgroundColor: Int? = null,
+    ): androidx.core.graphics.drawable.IconCompat? {


Same import

inukiwi and others added 3 commits March 3, 2026 13:49

Add support for progress styling on Android 16+

bfb5e9a

Merge branch 'home-assistant:main' into progress_style_notifications

90f98e9

Fix check on wrong progress bar icon

58d3bd8

home-assistant Bot added the cla-signed label Mar 3, 2026

inukiwi mentioned this pull request Mar 3, 2026

Add documentation for progress bar customization on Android home-assistant/companion.home-assistant#1297

Draft

7 tasks

TimoPtr reviewed Mar 5, 2026

View reviewed changes

Comment thread app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

inukiwi added 2 commits March 5, 2026 14:22

Refactor progress bar customization into separate methods

468a3b9

Handle non-numeric values in progress segments and points

d66ece6

inukiwi marked this pull request as ready for review March 6, 2026 11:59

Copilot AI review requested due to automatic review settings March 6, 2026 11:59

Copilot started reviewing on behalf of inukiwi March 6, 2026 12:00 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Fix fallback to theme accent color if dynamic accent color is not found

793f63e

TimoPtr reviewed Mar 23, 2026

View reviewed changes

Comment thread ...main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt Outdated

TimoPtr reviewed Mar 23, 2026

View reviewed changes

Comment thread ...main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt Outdated

TimoPtr reviewed Mar 23, 2026

View reviewed changes

Comment thread app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt Outdated

TimoPtr reviewed Mar 23, 2026

View reviewed changes

TimoPtr marked this pull request as draft March 23, 2026 13:59

inukiwi mentioned this pull request Apr 1, 2026

Add iOS Live Activities documentation home-assistant/companion.home-assistant#1303

Merged

7 tasks

inukiwi and others added 2 commits June 15, 2026 17:43

Use JSON to flatten objects and lists in notification data

bc2ba28

Merge branch 'home-assistant:main' into progress_style_notifications

e5e938c

github-advanced-security AI found potential problems Jun 15, 2026

View reviewed changes

inukiwi added 2 commits June 15, 2026 23:47

Linter fixes for code style

15a5f11

Move notification progress bar icon creation to helper function

3a20a0f

github-advanced-security AI found potential problems Jun 16, 2026

View reviewed changes

Comment thread app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt Fixed

Comment thread app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt Fixed

Linter fix for reading SDK version

e96da1c

inukiwi marked this pull request as ready for review June 17, 2026 15:26

TimoPtr reviewed Jun 18, 2026

View reviewed changes

TimoPtr marked this pull request as draft June 29, 2026 11:55

		if (progressStartIcon.startsWith("mdi:") && progressStartIcon.substringAfter("mdi:").isNotBlank()) {
		val iconName = progressStartIcon.split(":")[1]

		if (progressEndIcon.startsWith("mdi:") && progressEndIcon.substringAfter("mdi:").isNotBlank()) {
		val iconName = progressEndIcon.split(":")[1]

Uh oh!

Uh oh!

Conversation

inukiwi commented Mar 3, 2026

Summary

Checklist

Screenshots

Link to pull request in documentation repositories

Any other notes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-advanced-security AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

inukiwi commented Jun 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants