Fix Full data toggle overlap in AI explorations

lumen/ai/editors.py

@@ -48,6 +48,27 @@
     from .report import Task
 
 
+_PAGINATED_TABLE_STYLES = """
+.tabulator-footer {
+  display: flex;
+  text-align: left;
+  padding: 0px;
+}
+/* Tabulator drops its page-number group when the footer overflows
+   horizontally, so let the paginator wrap to keep the pages reachable.
+   The Panel theme stylesheet loads later and would otherwise win. */
+.tabulator .tabulator-footer .tabulator-paginator {
+  display: flex !important;
+  flex-wrap: wrap !important;
+  justify-content: flex-end !important;
+}
+.tabulator .tabulator-footer .tabulator-pages {
+  display: inline-flex !important;
+  flex-wrap: wrap !important;
+}
+"""
+
+
 class LumenEditor(Viewer):
 
     component = param.ClassSelector(class_=Component)
@@ -207,36 +228,32 @@ def _update_component(self):
 
     async def _render_pipeline(self, pipeline):
         table = Table(
-            pipeline=pipeline, pagination='remote',
-            min_height=200, sizing_mode="stretch_both", stylesheets=[
-            """
-            .tabulator-footer {
-            display: flex;
-            text-align: left;
-            padding: 0px;
-            }
-            """
-            ]
-        )
-        controls = Row(
-            styles={'position': 'absolute', 'right': '40px', 'top': '-35px'}
+            pipeline=pipeline, pagination='remote', min_height=200,
+            sizing_mode="stretch_both", stylesheets=[_PAGINATED_TABLE_STYLES],
         )
+        layout = Column(table)
         for sql_limit in pipeline.sql_transforms:
             if isinstance(sql_limit, SQLLimit):
                 break
         else:
-            sql_limit = None
-        if sql_limit:
-            limited = len(pipeline.data) == sql_limit.limit
-            if limited:
-                def unlimit(e):
-                    sql_limit.limit = None if e.new else 1_000_000
-                full_data = Checkbox(
-                    label='Full data', width=100, visible=limited
-                )
-                full_data.param.watch(unlimit, 'value')
-                controls.insert(0, full_data)
-        return Column(controls, table)
+            return layout
+        if len(pipeline.data) != sql_limit.limit:
+            return layout
+
+        # Restore the limit this query actually ran with, so unchecking cannot
+        # silently widen a query that was limited more tightly than the default.
+        limit = sql_limit.limit
+
+        def unlimit(e):
+            sql_limit.limit = None if e.new else limit
+
+        full_data = Checkbox(label='Full data', height=36, margin=0)
+        full_data.param.watch(unlimit, 'value')
+        layout.append(Row(
+            full_data, height=36, sizing_mode='stretch_width',
+            styles={'justify-content': 'flex-end', 'align-items': 'center'},
+        ))
+        return layout
 
     async def render_context(self):
         view = self.component

lumen/tests/ai/test_editors.py

@@ -18,6 +18,7 @@
 from lumen.base import Component
 from lumen.pipeline import Pipeline
 from lumen.sources.duckdb import DuckDBSource
+from lumen.transforms.sql import SQLLimit
 
 
 class MockComponent(Component):
@@ -202,6 +203,60 @@ def test_render_controls_inserts_add_filter_menu(sql_pipeline_editor):
     assert "Add Filter" in labels
 
 
+@pytest.fixture
+def limited_sql_pipeline_editor(monkeypatch):
+    """Return an editor whose source data exceeds its SQL limit."""
+    source = DuckDBSource(tables={
+        'tiny': """
+            SELECT * FROM (
+              VALUES (1,'A'),
+                     (2,'B'),
+                     (3,'C'),
+                     (4,'D')
+            ) AS t(id, category)
+        """
+    })
+    pipeline = Pipeline(
+        source=source, table='tiny', sql_transforms=[SQLLimit(limit=3)]
+    )
+    monkeypatch.setattr(editors_module, 'ParamMethod', lambda *args, **kwargs: None)
+    return SQLEditor(component=pipeline, spec="SELECT * FROM tiny")
+
+
+@pytest.mark.asyncio
+async def test_render_pipeline_places_full_data_control_below_table(limited_sql_pipeline_editor):
+    editor = limited_sql_pipeline_editor
+    assert len(editor.component.data) == 3
+
+    layout = await editor._render_pipeline(editor.component)
+    table, controls = layout.objects
+
+    assert table._pane.stylesheets == [editors_module._PAGINATED_TABLE_STYLES]
+    assert controls.sizing_mode == 'stretch_width'
+    assert controls.styles == {
+        'justify-content': 'flex-end',
+        'align-items': 'center',
+    }
+    full_data = controls.objects[0]
+    assert full_data.label == "Full data"
+
+    full_data.value = True
+    assert editor.component.sql_transforms[0].limit is None
+    assert len(editor.component.data) == 4
+
+    # Unchecking restores this query's own limit, not a hardcoded default.
+    full_data.value = False
+    assert editor.component.sql_transforms[0].limit == 3
+    assert len(editor.component.data) == 3
+
+
+@pytest.mark.asyncio
+async def test_render_pipeline_omits_empty_full_data_row(sql_pipeline_editor):
+    layout = await sql_pipeline_editor._render_pipeline(sql_pipeline_editor.component)
+
+    assert len(layout.objects) == 1
+
+
 @pytest.fixture
 def xarray_pipeline_editor(monkeypatch):
     """SQLEditor over an xarray source so coordinate dimensions are exercised."""