react 16 to react-18 - #97
Open
jancy01 wants to merge 6 commits into
Open
Conversation
putvande
reviewed
May 13, 2025
| "react": "18.2.0", | ||
| "react-dom": "18.2.0", | ||
| "react-redux": "9.1.2", | ||
| "redux": "^5.0.0", |
There was a problem hiding this comment.
Can we update these versions to their latest (sensible) versions.
React and React-dom to 18.3.1 and react-redux to 9.2.0.
Would we be able to upgrade Redux to a newer version? The version used is over 6 years old.
What about React, can we (and should we) use 19?
putvande
reviewed
May 13, 2025
|
|
||
| const generateOutput = (template, props, options) => { | ||
| const method = props.dataSource && props.dataSource.hydrate ? 'hydrate' : 'render' | ||
| const method = props.dataSource && props.dataSource.hydrate ? 'hydrate' : props.dataSource.hydrateRoot ? 'hydrateRoot' : 'render' |
There was a problem hiding this comment.
Can this be done in a different way? Nested ternary is difficult to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested this pr #95 with all the lib folder to test ssg-hx-uk and static-site-generator sites to use react18.
In this pr updating the version of react and react-dom to 18.2.0 and react-redux to 9.1.2 and redux to 5.0.0. so we can use this version in consuming repo like ssg-purple-parking, ssg-hx-uk and static-site-generator sites . Once this release is mreged to master , then using this version in ssg-purple-parking to use react18.20.0 .We will have testers involved and PM to check the error data etc.