Skip to content

Fix evil-snipe warnings - #99

Open
jamescherti wants to merge 12 commits into
hlissner:masterfrom
jamescherti:fix-warnings
Open

Fix evil-snipe warnings#99
jamescherti wants to merge 12 commits into
hlissner:masterfrom
jamescherti:fix-warnings

Conversation

@jamescherti

@jamescherti jamescherti commented Jan 26, 2025

Copy link
Copy Markdown
  • Rename keymap to evil-snipe-keymap and declare it dynamically to fix prefix warning and lexical binding scope
  • Add evil-snipe- prefix to turn-on/off override functions
  • Capitalize package summary and add standard keywords
  • Fix unescaped single quotes and column 0 parentheses in docstrings
  • Wrap evil-snipe-char-fold docstring to 80 characters
  • Add missing docstrings to internal functions and format arguments
  • Add forward declarations for evil-snipe-(override-)local-mode
  • Fix: Warning: in defcustom for ‘evil-snipe-scope’: ‘const’ with quoted value
  • First line is not a complete sentence
  • Fix: Docstring wider than 80 characters
  • Fix: Alias should be declared before its referent
  • Fix: Reference to free variable ‘evil-snipe-parent-transient-map’
  • Fix: Unused lexical variable ‘match’
  • Fix: You should depend on (emacs "25.1") if you need `char-fold-to-regexp'.
  • Add: -- lexical-binding: t; --
  • Add .gitignore
  • Docstring has wrong usage of unescaped single quotes
  • Warning: Unused lexical argument ‘count’

This commit fixes:
- Alias for ‘evil-snipe-local-mode-map’ should be declared before its referent
- Alias for ‘evil-snipe-override-local-mode-map’ should be declared before its referent
- Alias for ‘evil-snipe-aliases’ should be declared before its referent
- evil-snipe.el:72:12: Warning: custom-declare-variable
  ‘evil-snipe-scope’ docstring has wrong usage of unescaped single
  quotes (use \=' or different quoting such as `...')
- evil-snipe.el:123:12: Warning: custom-declare-variable
  ‘evil-snipe-show-prompt’ docstring has wrong usage of unescaped single
  quotes (use \=' or different quoting such as `...')
- evil-snipe.el:142:12: Warning: custom-declare-variable
  ‘evil-snipe-aliases’ docstring has wrong usage of unescaped single
  quotes (use \=' or different quoting such as `...')
- evil-snipe.el:182:12: Warning: custom-declare-variable
  ‘evil-snipe-tab-increment’ docstring has wrong usage of unescaped
  single quotes (use \=' or different quoting such as `...')
- evil-snipe.el:191:12: Warning: custom-declare-variable
  ‘evil-snipe-char-fold’ docstring has wrong usage of unescaped single
  quotes (use \=' or different quoting such as `...')
- Rename keymap to evil-snipe-keymap and declare it dynamically to fix prefix
  warning and lexical binding scope
- Add evil-snipe- prefix to turn-on/off override functions
- Capitalize package summary and add standard keywords
- Fix unescaped single quotes and column 0 parentheses in docstrings
- Wrap evil-snipe-char-fold docstring to 80 characters
- Add missing docstrings to internal functions and format arguments
- Add forward declarations for evil-snipe-(override-)local-mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant