Skip to content

chore(deps): update brace-expansion from 1.1.16 to 1.1.21 in package.json and package-lock.json - #2687

Merged
danielmarv merged 1 commit into
hiero-ledger:mainfrom
MonaaEid:chore/2686-update-brace-expansion
Oct 1, 2026
Merged

danielmarv merged 1 commit into
hiero-ledger:mainfrom
MonaaEid:chore/2686-update-brace-expansion

Conversation

@MonaaEid

@MonaaEid MonaaEid commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Description:
This pull request updates the brace-expansion dependency to the latest patch version in the GitHub Actions scripts. This change ensures improved security and compatibility for the scripts.

Dependency updates:

  • Updated the brace-expansion package version from 1.1.18 to 1.1.21 in package-lock.json and updated the version constraint in package.json to ^1.1.21. This brings in the latest fixes and improvements for this dependency.

Related issue(s):
Fixes #2686

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…json and package-lock.json

Signed-off-by: MonaaEid <monaa_eid@hotmail.com>
@MonaaEid
MonaaEid requested review from a team as code owners October 1, 2026 16:16
@MonaaEid
MonaaEid requested review from danielmarv and leninmehedy and a balanced review from Copilot October 1, 2026 16:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added approved Issue has been approved by team member dependencies Pull requests that update a dependency file labels Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: hiero-ledger/hiero-sdk-python/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1571ee95-42b3-46cb-8b81-e1248738160f

📥 Commits

Reviewing files that changed from the base of the PR and between 4229ee8 and 0870127.

⛔ Files ignored due to path filters (1)
  • .github/scripts/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • .github/scripts/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The GitHub scripts package updates its brace-expansion override from ^1.1.16 to ^1.1.21.

Changes

Dependency override update

Layer / File(s) Summary
Update dependency override
.github/scripts/package.json
The brace-expansion override changes to ^1.1.21.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 08701

The GitHub scripts dependency now resolves to 1.1.21, addressing the reported vulnerability. No concrete merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 08701

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/scripts/package.json: The brace-expansion override changes from ^1.1.16 to ^1.1.21.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency update and the affected package files. The stated source version differs from the pull request description, but the title remains directly related to the ma…
Description check ✅ Passed The description explains the brace-expansion update, its security objective, affected files, and linked issue. It is directly related to the changeset.
Linked Issues check ✅ Passed Issue #2686 requires the project to address the vulnerable brace-expansion versions earlier than 1.1.21. .github/scripts/package.json changes the brace-expansion override from ^1.1.16 to `^1.1…
Out of Scope Changes check ✅ Passed The reviewed change updates only the brace-expansion dependency override in .github/scripts/package.json. This change directly supports issue #2686. No unrelated code or behavior changes are shown…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added open to community review PR is open for community review and feedback queue:junior-committer PR awaiting initial quality review labels Oct 1, 2026
@github-actions github-actions Bot added queue:committers PR awaiting committer technical review and removed queue:junior-committer PR awaiting initial quality review labels Oct 1, 2026
@danielmarv
danielmarv merged commit 9adec02 into hiero-ledger:main Oct 1, 2026
25 of 28 checks passed
@MonaaEid MonaaEid added this to the v0.3.0 milestone Oct 1, 2026
@MonaaEid
MonaaEid deleted the chore/2686-update-brace-expansion branch October 1, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Issue has been approved by team member dependencies Pull requests that update a dependency file open to community review PR is open for community review and feedback queue:committers PR awaiting committer technical review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security vulnerability in brace-expansion dependency

5 participants