Skip to content

Document that ASSIGNED_PORTS is a string->string map - #83

Merged
dzbarsky merged 1 commit into
hermeticbuild:masterfrom
djmitche:string-string-map
Aug 7, 2026
Merged

Document that ASSIGNED_PORTS is a string->string map#83
dzbarsky merged 1 commit into
hermeticbuild:masterfrom
djmitche:string-string-map

Conversation

@djmitche

@djmitche djmitche commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

I noticed this while trying to unmarshal it to map[string]int in go!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56e7dbcf1c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/itest.md
@djmitche
djmitche force-pushed the string-string-map branch from 56e7dbc to 4930d6f Compare August 7, 2026 15:08

@dzbarsky dzbarsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dzbarsky
dzbarsky merged commit bc91ccf into hermeticbuild:master Aug 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants