Skip to content

Fix deferred service dependency health check - #77

Merged
darkrift merged 1 commit into
hermeticbuild:masterfrom
adamf-oai:adamf/fix-deferred-dependency-healthcheck
Aug 6, 2026
Merged

Fix deferred service dependency health check#77
darkrift merged 1 commit into
hermeticbuild:masterfrom
adamf-oai:adamf/fix-deferred-dependency-healthcheck

Conversation

@adamf-oai

Copy link
Copy Markdown
Contributor

Summary

  • wait for the actual non-deferred dependency when starting a deferred service
  • stop handling the start request after a dependency health-check failure
  • cover the behavior with a deferred service that depends on a healthy non-deferred service

Root cause

handleStart iterated over dependency labels but called WaitUntilHealthy on the deferred service being started. Because that service has no process yet, the health check can dereference a nil process and break the /start request.

Validation

  • bazel test //deferred:deferred_service_test --test_output=errors --nocache_test_results from tests/
  • bazel test //... --test_output=errors from tests/ (43 tests passed)

@adamf-oai
adamf-oai marked this pull request as ready for review August 3, 2026 23:18
@darkrift
darkrift merged commit 8693c18 into hermeticbuild:master Aug 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants