Repository navigation
Keep the whole outline of every drawing on the website and in the ebook - #480
Merged
Merged
Conversation
dvisvgm crops each TikZ picture to its bounding box, and TikZ leaves the line width out of that box. What sticks out gets cut off: the tips of the 2 mm decision diamonds (Flowchart 3.1, "Ready?"), the ends of thick lines, the top "H" in the ethanol figure. 13 of the book's 23 drawings lost a stroke somewhere, eleven flowcharts among them. Every picture in the HTML builds now ends 1.5 mm outside its bounding box. The printed book does not read these files, so its layout does not move. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… main Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The website and the ebook cut off the outer strokes of the book's drawings. The most visible case is the tip of the "Ready?" diamond in Flowchart 3.1, which is flat instead of pointed.
Why: dvisvgm crops every TikZ picture to its bounding box, and TikZ leaves the line width out of that box. Anything that sticks out beyond the geometric outline gets cut: the miter tips of the 2 mm
decisiondiamonds, the ends of thick lines, and the top "H" in the ethanol oxidation figure. I rendered all 23 TikZ drawings of the website with a widened frame and counted what appears outside the original one. 13 of the 23 lose a stroke somewhere, 11 of them flowcharts: 3.1, 3.2, 3.3, 4.1, 4.2, 7.2, 7.4, 7.5, 7.6, 7.7 and 10.1, plus figures 1.1 and 12.3. The deepest cut is 0.36 % of the picture's width.Fix:
website.cfgandtex4ebook.cfggive every TikZ picture 1.5 mm of room beyond its bounding box (an invisible path inexecute at end picture). The printed book reads neither file, so the PDF layout does not move.The second commit adds
make pr, so a change reaches GitHub as a pull request and never as a push to main.Test plan
book3x.svg) shows a pointed "Ready?" diamond, and the boxes no longer touch the edges🤖 Generated with Claude Code