Skip to content

ci: the history job downloads the bench report by name, so it finds it - #25

Merged
sergeytimoshin merged 3 commits into
mainfrom
sergei/history-artifact-download
Oct 17, 2026
Merged

sergeytimoshin merged 3 commits into
mainfrom
sergei/history-artifact-download

Conversation

@sergeytimoshin

Copy link
Copy Markdown
Collaborator

The proof timing history on main never started: download-artifact extracts a single artifact matched by a pattern straight into path, without the artifact's directory, and proof-timing-history.sh looks for proof-timing-*/report.json.

  • ci.yml: the proof-timing-history job downloads proof-timing-chrome by name into reports/proof-timing-chrome.

The first push to main after this creates the proof-timing branch and comments the report on the commit; pull requests then show a before row.

download-artifact extracts a single artifact matched by a pattern straight
into the path, without the artifact's directory; the history script looked
for proof-timing-*/report.json and found nothing, so the proof-timing branch
was never written.
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Proof timing: chrome

After: this pull request at 28bdaa3. No report of main to compare with yet.

Medians of one browser, by shape (notes → outputs). Runner numbers are for comparing commits, not for how fast a device is.

by scenario 1 → 2 2 → 2 4 → 2 8 → 2 16 → 2 24 → 2 merge 24 → 1
first run, including download 3.04 s (download: 0.91 s, 8.8 MiB) 4.71 s (download: 0.43 s, 15.6 MiB) 6.66 s (download: 0.57 s, 28.9 MiB) 12.81 s (download: 0.86 s, 55.9 MiB) 23.52 s (download: 1.46 s, 109.5 MiB) 37.69 s (download: 2.05 s, 171.6 MiB) 35.57 s (download: 1.88 s, 165.0 MiB)
warm 0.59 s 0.97 s 1.68 s 3.24 s 5.62 s 9.20 s 9.26 s
first run after restart 1.12 s 1.54 s 2.47 s 4.57 s 8.28 s 12.76 s 12.59 s
repeated after restart 0.73 s 0.99 s 1.67 s 3.17 s 5.75 s 9.16 s 8.92 s
by stage 1 → 2 2 → 2 4 → 2 8 → 2 16 → 2 24 → 2 merge 24 → 1
key load 0.19 s 0.27 s 0.49 s 0.92 s 2.27 s 3.06 s 3.05 s
witness 0.00 s 0.00 s 0.00 s 0.00 s 0.00 s 0.00 s 0.00 s
prove 0.62 s 0.96 s 1.63 s 3.16 s 5.56 s 9.14 s 8.92 s

The proof's verification is a check of the prover, not a cost of proving,
and a change of two milliseconds is not a percentage.
@sergeytimoshin
sergeytimoshin force-pushed the sergei/history-artifact-download branch from 0d125b8 to 28bdaa3 Compare October 17, 2026 10:59
@sergeytimoshin
sergeytimoshin merged commit c7595d0 into main Oct 17, 2026
4 checks passed
@sergeytimoshin
sergeytimoshin deleted the sergei/history-artifact-download branch October 17, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant