docs: 重複検知の仕様を確定させる - #72
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough重複判定の正規化と複合キー仕様を明確化しました。登録・編集時の重複検知、既存ボトルへの遷移、UIモック10枚への更新を要件と完了基準に反映しました。 Changes重複検知仕様とMVP基準
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/data-model.md`:
- Around line 43-45: Update the判定キー specification to define a collision-safe
deterministic encoding: either reject the delimiter in the shared server-side
schema or escape/length-prefix every field before joining. Explicitly state
whether空白除去 trims only outer whitespace or removes all whitespace, define the
exact canonical string forms for age and isLimited, and require POST and PATCH
to apply the same canonicalization.
In `@docs/requirements.md`:
- Around line 58-60: Update the MVP completion criterion in docs/requirements.md
so duplicate detection is explicitly verified during both bottle registration
and editing, including displaying the existing bottle and allowing navigation to
its detail view without adding quantity.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 48c14380-4009-4ed1-931a-c3cb0876d03f
⛔ Files ignored due to path filters (1)
docs/ui-mockups/05・06-重複検出.pngis excluded by!**/*.png
📒 Files selected for processing (3)
CLAUDE.mddocs/data-model.mddocs/requirements.md
関連 issue
resolve #71
やったこと
概要
重複検知の要件が登録しか想定しておらず、記述と実態も食い違っていたため、実装(#57)の前に仕様を確定させた。
変更点
requirements.md/data-model.md)data-model.mdに明記05・06-重複検出.pngを追跡し、モック枚数を 9 → 10 に更新受け入れ条件(セルフチェック)
docs/requirements.md「5. スコープ」の重複ボトルの検知が、登録・編集の両方で検知することを示しているrequirements.mdとdata-model.mdの両方)docs/data-model.mdが、判定キーの区切りに入力に現れない文字を使うことを示しているdocs/ui-mockups/05・06-重複検出.pngがリポジトリに追跡されている動作確認
pnpm lintが通るpnpm format:checkが通るpnpm typecheckが通るpnpm testが通るIssue 要件外の対応(あれば)
**
CLAUDE.mdの枚数も 9 → 10 に更新した。**受け入れ条件はrequirements.mdの 2 箇所だけを挙げていたが、CLAUDE.mdの References にも枚数が書かれており、片方だけ直すと新しい食い違いが生まれるため。備考
toLowerCase()を使う(toLocaleLowerCase()はトルコ語ロケールでI→ıになりIslayとislayが別物になる)Summary by CodeRabbit