Skip to content

fix: add haxe@^4.1 compatibility - #45

Open
qkdreyer wants to merge 1 commit into
haxetink:masterfrom
qkdreyer:patch-1
Open

fix: add haxe@^4.1 compatibility#45
qkdreyer wants to merge 1 commit into
haxetink:masterfrom
qkdreyer:patch-1

Conversation

@qkdreyer

@qkdreyer qkdreyer commented Sep 9, 2020

Copy link
Copy Markdown

No description provided.

@kevinresol

kevinresol commented Sep 10, 2020

Copy link
Copy Markdown
Member

This seems to break 4.0 and 3.x, and more importantly omitted the success case.

@back2dos

Copy link
Copy Markdown
Member

Yep, this is not good. If your intention was to keep the haxe.Exception, then adding an #if (haxe_ver >= 4.1) catch (e:haxe.Exception) clause should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants