Repository navigation
fix(quic): suppress authenticated packet replays before recovery - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An authenticated QUIC packet replay currently runs frame handlers again and clears pending PTO probes. This also happens after ACK-of-ACK pruning removes the packet's ACK range: the same PATH_CHALLENGE schedules another response and STREAM data queues another readable event.
Keep a separate receive history for each packet-number space and discard authenticated duplicates before key rotation, frame dispatch, and recovery resets, as required by RFC 9000 section 12.3. History retains up to 256 ranges with a monotone floor for evicted packets; in-order traffic uses one range. ACK pruning does not erase replay history. New packet-number retransmissions and unseen gaps above the floor remain eligible. Existing byte accounting and authenticated-packet idle handling remain intact.
Validation:
This is a correctness repair with no end-to-end throughput claim. Receive history adds at most 4 KiB of range storage per number space; general QUIC recovery is not established by these focused tests.
Ordinary H3 guards used immutable standalone release binaries with matched compiler/profile/dependency fingerprints and a fixed hfast server. Three alternating pairs per workload completed 14,352,384 requests including warmups with zero errors. Median RPS changes were -0.311% (c1/p1) and -0.370% (c16/p64); all six pairs were adverse, with a worst pair of -3.279%. Small ordinary-path cost remains unresolved under known WSL measurement uncertainty. These results establish neither a speedup nor equivalence; no repeated noise controls or threshold relaxation were used.